| Message ID | 20240801143004.993503-2-ninad@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: aspeed: system1: IBM System1 | expand |
On Thu, 2024-08-01 at 09:30 -0500, Ninad Palsule wrote: > Updated MAX31785a pmbus based fans in the device tree. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 95 +++++++++++++++++++ > 1 file changed, 95 insertions(+) I've applied this, not because I think it's a good idea, but because it's something the OpenBMC tree already supports. If that weren't the case then I would require that you work with upstream on the bindings as usual. That said, please now do that work with upstream to get a sensible binding together. The less difference we have from upstream the better. Thanks, Andrew PS: In the future, can you please try to be more descriptive in your patch subject than "IBM System1 BMC update"? At the very least I would like it to say something about fan configuration in this instance.
Hi Andrew, On 8/4/24 23:18, Andrew Jeffery wrote: > On Thu, 2024-08-01 at 09:30 -0500, Ninad Palsule wrote: >> Updated MAX31785a pmbus based fans in the device tree. >> >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> >> --- >> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 95 +++++++++++++++++++ >> 1 file changed, 95 insertions(+) > I've applied this, not because I think it's a good idea, but because > it's something the OpenBMC tree already supports. If that weren't the > case then I would require that you work with upstream on the bindings > as usual. Thanks! > > That said, please now do that work with upstream to get a sensible > binding together. The less difference we have from upstream the better. Yes, I will start working on this. > > Thanks, > > Andrew > > PS: In the future, can you please try to be more descriptive in your > patch subject than "IBM System1 BMC update"? At the very least I would > like it to say something about fan configuration in this instance. will do. Thanks! Regards, Ninad Palsule
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts index f3efecc7eb8d0..cb3063413d1fa 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts @@ -770,11 +770,106 @@ &i2c6 { fan-controller@52 { compatible = "maxim,max31785a"; reg = <0x52>; + #address-cells = <1>; + #size-cells = <0>; + + fan0: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan1: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan2: fan@2 { + compatible = "pmbus-fan"; + reg = <2>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan3: fan@3 { + compatible = "pmbus-fan"; + reg = <3>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan4: fan@4 { + compatible = "pmbus-fan"; + reg = <4>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; fan-controller@54 { compatible = "maxim,max31785a"; reg = <0x54>; + #address-cells = <1>; + #size-cells = <0>; + + fan5: fan@0 { + compatible = "pmbus-fan"; + reg = <0>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; + + fan6: fan@1 { + compatible = "pmbus-fan"; + reg = <1>; + tach-pulses = <2>; + maxim,fan-rotor-input = "tach"; + maxim,fan-pwm-freq = <25000>; + maxim,fan-dual-tach; + maxim,fan-no-watchdog; + maxim,fan-no-fault-ramp; + maxim,fan-ramp = <2>; + maxim,fan-fault-pin-mon; + }; }; eeprom@55 {
Updated MAX31785a pmbus based fans in the device tree. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+)