SV: [PATCH 01/18] Replace TARGET_OS by HOST_KERNEL/HOST_LIBC

Hi Yann,

What problem is this patch solving?

Br,
Kim

Hi,

I ask myself which is the good override:

SRC_URI:>TARGET_OS_darwin = " file://patch-shobj-conf.patch" ?
SRC_URI:>TARGET_KERNEL_darwin = " file://patch-shobj-conf.patch" ?
SRC_URI:>HOST_OS_darwin = " file://patch-shobj-conf.patch" ?
SRC_URI:>HOST_KERNEL_darwin = " file://patch-shobj-conf.patch" ?

For me it should be SRC_URI:>HOST_KERNEL_darwin = "
file://patch-shobj-conf.patch"

*_KERNEL_* override was been added in order to avoid darwin9 darwin10
stuff if *_OS_* override
then TARGET or HOST. In most recipe, shouldn't be HOST (TARGET
awareness shouldn't be only for cross tools?)

These patches is for clean up and standardize the actual work.
Sorry my patches are really bad.

Regards,

2015-01-05 11:27 GMT+01:00 Kim Højgaard-Hansen <Kim.Hansen@prevas.dk>:
> Hi Yann,
>
> What problem is this patch solving?
>
> Br,
> Kim
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] p&#229; vegne af Yann Diorcet [diorcet.yann@gmail.com]
> Sendt: 6. august 2014 21:17
> Til: dev@oe-lite.org
> Emne: [PATCH 01/18] Replace TARGET_OS by HOST_KERNEL/HOST_LIBC
>
> ---
>  recipes/icu/icu.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes/icu/icu.inc b/recipes/icu/icu.inc
> index 1958b2f..29749ac 100644
> --- a/recipes/icu/icu.inc
> +++ b/recipes/icu/icu.inc
> @@ -55,7 +55,7 @@ inherit auto-package-libs
>  AUTO_PACKAGE_LIBS = "icudata icuuc icui18n icule iculx icutu icuio icutest"
>  AUTO_PACKAGE_LIBS_LIBSUFFIXES:HOST_LIBC_mingw = ",${@''.join(d.get('PV').split('.')[:2])}"
>  AUTO_PACKAGE_LIBS_LIBDIR:HOST_LIBC_mingw = "${libdir}::${AUTO_PACKAGE_LIBS_LIBSUFFIXES}"
> -SOLIBS:HOST_OS_mingw32 = ".dll"
> +SOLIBS:HOST_LIBC_mingw = ".dll"
>  AUTO_PACKAGE_LIBS_DEV_DEPENDS = "${PN}-dev_${PV}"
>  FILES_${PN}-libicuuc:>HOST_LIBC_mingw = " ${libdir}/icudt*${SOLIBS}"
>  FILES_${PN}-libicui18n:>HOST_LIBC_mingw = " ${libdir}/icuin*${SOLIBS}"
> --
> 2.0.1
>
> _______________________________________________
> dev mailing list
> dev@oe-lite.org
> http://lists.oe-lite.org/mailman/listinfo/dev

Hi Yann,

I don't think your patches are bad in any way, I just have to ask more questions since I'm new to this base maintainership :)

Thanks for explaining, along with esbens explanation it seems it should just be merged.

/Kim

Hi,
Or maybe delay that stuff. And do the clean up in one row later.

Yann

2015-01-05 12:36 GMT+01:00 Kim Højgaard-Hansen <Kim.Hansen@prevas.dk>:
> Hi Yann,
>
> I don't think your patches are bad in any way, I just have to ask more questions since I'm new to this base maintainership :)
>
> Thanks for explaining, along with esbens explanation it seems it should just be merged.
>
> /Kim
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: Yann Diorcet [diorcet.yann@gmail.com]
> Sendt: 5. januar 2015 12:27
> Til: Kim Højgaard-Hansen
> Cc: dev@oe-lite.org
> Emne: Re: [PATCH 01/18] Replace TARGET_OS by HOST_KERNEL/HOST_LIBC
>
> Hi,
>
> I ask myself which is the good override:
>
> SRC_URI:>TARGET_OS_darwin = " file://patch-shobj-conf.patch" ?
> SRC_URI:>TARGET_KERNEL_darwin = " file://patch-shobj-conf.patch" ?
> SRC_URI:>HOST_OS_darwin = " file://patch-shobj-conf.patch" ?
> SRC_URI:>HOST_KERNEL_darwin = " file://patch-shobj-conf.patch" ?
>
> For me it should be SRC_URI:>HOST_KERNEL_darwin = "
> file://patch-shobj-conf.patch"
>
> *_KERNEL_* override was been added in order to avoid darwin9 darwin10
> stuff if *_OS_* override
> then TARGET or HOST. In most recipe, shouldn't be HOST (TARGET
> awareness shouldn't be only for cross tools?)
>
> These patches is for clean up and standardize the actual work.
> Sorry my patches are really bad.
>
> Regards,
>
> 2015-01-05 11:27 GMT+01:00 Kim Højgaard-Hansen <Kim.Hansen@prevas.dk>:
>> Hi Yann,
>>
>> What problem is this patch solving?
>>
>> Br,
>> Kim
>> ____________________________
>> KIM HØJGAARD-HANSEN
>> Software Developer
>>
>> Prevas A/S
>> Hedeager 1
>> DK-8200 Århus N
>>
>> Central +45 87438070
>> Direct/Mobile +45 51547387
>> kim.hansen@prevas.dk
>> www.prevas.dk
>> ________________________________________
>> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] p&#229; vegne af Yann Diorcet [diorcet.yann@gmail.com]
>> Sendt: 6. august 2014 21:17
>> Til: dev@oe-lite.org
>> Emne: [PATCH 01/18] Replace TARGET_OS by HOST_KERNEL/HOST_LIBC
>>
>> ---
>>  recipes/icu/icu.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes/icu/icu.inc b/recipes/icu/icu.inc
>> index 1958b2f..29749ac 100644
>> --- a/recipes/icu/icu.inc
>> +++ b/recipes/icu/icu.inc
>> @@ -55,7 +55,7 @@ inherit auto-package-libs
>>  AUTO_PACKAGE_LIBS = "icudata icuuc icui18n icule iculx icutu icuio icutest"
>>  AUTO_PACKAGE_LIBS_LIBSUFFIXES:HOST_LIBC_mingw = ",${@''.join(d.get('PV').split('.')[:2])}"
>>  AUTO_PACKAGE_LIBS_LIBDIR:HOST_LIBC_mingw = "${libdir}::${AUTO_PACKAGE_LIBS_LIBSUFFIXES}"
>> -SOLIBS:HOST_OS_mingw32 = ".dll"
>> +SOLIBS:HOST_LIBC_mingw = ".dll"
>>  AUTO_PACKAGE_LIBS_DEV_DEPENDS = "${PN}-dev_${PV}"
>>  FILES_${PN}-libicuuc:>HOST_LIBC_mingw = " ${libdir}/icudt*${SOLIBS}"
>>  FILES_${PN}-libicui18n:>HOST_LIBC_mingw = " ${libdir}/icuin*${SOLIBS}"
>> --
>> 2.0.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@oe-lite.org
>> http://lists.oe-lite.org/mailman/listinfo/dev
>
>
>
> --
> Diorcet Yann