SV: [base] busybox use flags corrections and additions

It is not clear what you are trying to do here.

I see one addition of a simple use flag, that make sense.

you move around some lines, that should be fixed.

But why are you removing the /'es ? Seems like you are working around some provides conflict by changing the busybox recipe?

Please add a little more information to your patches in the future, a log with the error you have run into would be helpful :)

/Kim

Hi Kim,

Yep - will add a bit more in the future.

Yes the /'es represented a conflict or rather they made the useflags not 
work. Meaning that nothing happend for a useflag, regardsless of set or 
unset, when the /'s where there. After removal of the /'s I could 
select/diselects features with the useflags.

Best regards
Mads

On 2014-12-17 14:53, Kim Højgaard-Hansen wrote:
> It is not clear what you are trying to do here.
>
> I see one addition of a simple use flag, that make sense.
>
> you move around some lines, that should be fixed.
>
> But why are you removing the /'es ? Seems like you are working around some provides conflict by changing the busybox recipe?
>
> Please add a little more information to your patches in the future, a log with the error you have run into would be helpful :)
>
> /Kim
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] på vegne af Mads Doré [dore@madsdore.dk]
> Sendt: 30. juli 2014 08:23
> Til: dev@oe-lite.org
> Emne: [base] busybox use flags corrections and additions
>
> ---
>   recipes/busybox/busybox-configure.inc | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/recipes/busybox/busybox-configure.inc b/recipes/busybox/busybox-configure.inc
> index c67242e..f67b3fa 100644
> --- a/recipes/busybox/busybox-configure.inc
> +++ b/recipes/busybox/busybox-configure.inc
> @@ -491,8 +491,8 @@ do_configure_busybox_buffers () {
>                  .config
>   }
>
> -# USE flag: enable feature verbose usage
> -BUSYBOX_SIMPLE_USE_FLAGS += "feature_verbose_usage"
> +# USE flag: enable man
> +BUSYBOX_SIMPLE_USE_FLAGS += "man:util/"
>
>   # USE flag: enable chpasswd
>   BUSYBOX_SIMPLE_USE_FLAGS += "chpasswd:util/"
> @@ -500,6 +500,9 @@ BUSYBOX_SIMPLE_USE_FLAGS += "chpasswd:util/"
>   # USE flag: enable acpid
>   BUSYBOX_SIMPLE_USE_FLAGS += "acpid:util/"
>
> +# USE flag: enable feature verbose usage
> +BUSYBOX_SIMPLE_USE_FLAGS += "feature_verbose_usage"
> +
>   # USE flag: enable unzip utility
>   BUSYBOX_SIMPLE_USE_FLAGS += "unzip:util/"
>
> @@ -687,10 +690,10 @@ BUSYBOX_SIMPLE_USE_FLAGS += "swaponoff:util/"
>   BUSYBOX_SIMPLE_USE_FLAGS += "feature_mount_loop"
>
>   # USE flag: enable sfdisk
> -BUSYBOX_SIMPLE_USE_FLAGS += "sfdisk:util/"
> +BUSYBOX_SIMPLE_USE_FLAGS += "sfdisk:util"
>
>   # USE flag: enable pidof
> -BUSYBOX_SIMPLE_USE_FLAGS += "pidof:util/"
> +BUSYBOX_SIMPLE_USE_FLAGS += "pidof:util"
>
>   BUSYBOX_SIMPLE_USE_FLAGS += "stat:util/:\
>   CONFIG_STAT,\
> @@ -729,6 +732,9 @@ BUSYBOX_SIMPLE_USE_FLAGS += "printf:util/"
>   # USE flag: enable readlink utility
>   BUSYBOX_SIMPLE_USE_FLAGS += "readlink:util/"
>
> +# USE flag: enable feature readlink follow
> +BUSYBOX_SIMPLE_USE_FLAGS += "feature_readlink_follow"
> +
>   # USE flag: enable readpath utility
>   BUSYBOX_SIMPLE_USE_FLAGS += "readpath:util/"
>
> --
> 2.0.3
>
> _______________________________________________
> dev mailing list
> dev@oe-lite.org
> http://lists.oe-lite.org/mailman/listinfo/dev

Ok, then make a pull-request for the additions you have. For the /'es changes, we need to see some logs, not convinced you have the right fix there

/Kim