| Message ID | 20241127180103.15076-3-phil@nwl.cc |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [libnftnl,1/3] set: Fix for array overrun when setting NFTNL_SET_DESC_CONCAT | expand |
diff --git a/tests/nft-expr_match-test.c b/tests/nft-expr_match-test.c index 53a8b849c4847..bc9f6ac1b9ac8 100644 --- a/tests/nft-expr_match-test.c +++ b/tests/nft-expr_match-test.c @@ -54,7 +54,7 @@ int main(int argc, char *argv[]) char buf[4096]; struct nftnl_expr_iter *iter_a, *iter_b; struct nftnl_expr *rule_a, *rule_b; - char data[16] = "0123456789abcdef"; + char data[] = "0123456789abcdef"; a = nftnl_rule_alloc(); b = nftnl_rule_alloc(); diff --git a/tests/nft-expr_target-test.c b/tests/nft-expr_target-test.c index 89de945e58348..a483e7ac24dd8 100644 --- a/tests/nft-expr_target-test.c +++ b/tests/nft-expr_target-test.c @@ -53,7 +53,7 @@ int main(int argc, char *argv[]) char buf[4096]; struct nftnl_expr_iter *iter_a, *iter_b; struct nftnl_expr *rule_a, *rule_b; - char data[16] = "0123456789abcdef"; + char data[] = "0123456789abcdef"; a = nftnl_rule_alloc(); b = nftnl_rule_alloc();
The 'data' arrays in match and target expression tests were undersized as they did not cover for the terminating NUL-char of the string used to initialize them. When passing such array to strdup(), the latter reads until after the defined array boundary. Fixes: 93483364369d8 ("src: get rid of cached copies of x_tables.h and xt_LOG.h") Signed-off-by: Phil Sutter <phil@nwl.cc> --- tests/nft-expr_match-test.c | 2 +- tests/nft-expr_target-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)