| Message ID | 20241125202634242hoMPn5q_ViCvJA9BygRYX@zte.com.cn |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [linux-next] netfilter: nf_tables: remove the genmask parameter | expand |
On Mon, Nov 25, 2024 at 08:26:34PM +0800, jiang.kun2@zte.com.cn wrote: > From: tuqiang <tu.qiang35@zte.com.cn> > > The genmask parameter is not used within the nf_tables_addchain function > body. It should be removed to simplify the function parameter list. > > Signed-off-by: tuqiang <tu.qiang35@zte.com.cn> > Signed-off-by: Jiang Kun <jiang.kun2@zte.com.cn> > Cc: xu xin <xu.xin16@zte.com.cn> > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > Cc: Jozsef Kadlecsik <kadlec@netfilter.org> > Cc: David S. Miller <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Simon Horman <horms@kernel.org> > --- > net/netfilter/nf_tables_api.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 588a2757986c..e9925473c34a 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -2496,9 +2496,8 @@ int nft_chain_add(struct nft_table *table, struct nft_chain *chain) static u64 chain_id; -static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask, - u8 policy, u32 flags, - struct netlink_ext_ack *extack) +static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 policy, + u32 flags, struct netlink_ext_ack *extack) { const struct nlattr * const *nla = ctx->nla; struct nft_table *table = ctx->table; @@ -2936,7 +2935,7 @@ static int nf_tables_newchain(struct sk_buff *skb, const struct nfnl_info *info, extack); } - return nf_tables_addchain(&ctx, family, genmask, policy, flags, extack); + return nf_tables_addchain(&ctx, family, policy, flags, extack); } static int nft_delchain_hook(struct nft_ctx *ctx,