diff mbox series

[libnftnl] expr: dynset: validate expressions are of nested type

Message ID 20240922221606.425225-1-fw@strlen.de
State Accepted, archived
Headers show
Series [libnftnl] expr: dynset: validate expressions are of nested type | expand

Commit Message

Florian Westphal Sept. 22, 2024, 10:16 p.m. UTC 
This was not handled in the switch statement so far.
Also, use proper max value, SET_MAX is larger than whats is needed for
parsing.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 src/expr/dynset.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/src/expr/dynset.c b/src/expr/dynset.c
index 8a159f8ff520..9d2bfe5e206b 100644
--- a/src/expr/dynset.c
+++ b/src/expr/dynset.c
@@ -118,7 +118,7 @@  static int nftnl_expr_dynset_cb(const struct nlattr *attr, void *data)
 	const struct nlattr **tb = data;
 	int type = mnl_attr_get_type(attr);
 
-	if (mnl_attr_type_valid(attr, NFTA_SET_MAX) < 0)
+	if (mnl_attr_type_valid(attr, NFTA_DYNSET_MAX) < 0)
 		return MNL_CB_OK;
 
 	switch (type) {
@@ -139,6 +139,7 @@  static int nftnl_expr_dynset_cb(const struct nlattr *attr, void *data)
 			abi_breakage();
 		break;
 	case NFTA_DYNSET_EXPR:
+	case NFTA_DYNSET_EXPRESSIONS:
 		if (mnl_attr_validate(attr, MNL_TYPE_NESTED) < 0)
 			abi_breakage();
 		break;
@@ -225,7 +226,7 @@  static int
 nftnl_expr_dynset_parse(struct nftnl_expr *e, struct nlattr *attr)
 {
 	struct nftnl_expr_dynset *dynset = nftnl_expr_data(e);
-	struct nlattr *tb[NFTA_SET_MAX+1] = {};
+	struct nlattr *tb[NFTA_DYNSET_MAX+1] = {};
 	struct nftnl_expr *expr, *next;
 	int ret = 0;