| Message ID | tencent_BA28CC6897B7C95A92EB8C580B5D18589105@qq.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc/prom_init: fix the improper check of prom_getprop | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On Fri, 19 Nov 2021 17:12:18 +0800, Peiwei Hu wrote: > prom_getprop() can return PROM_ERROR. Binary operator can not identify it. > > Applied to powerpc/next. [1/1] powerpc/prom_init: fix the improper check of prom_getprop https://git.kernel.org/powerpc/c/869fb7e5aecbc163003f93f36dcc26d0554319f6 cheers
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 18b04b08b983..f845065c860e 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -2991,7 +2991,7 @@ static void __init fixup_device_tree_efika_add_phy(void) /* Check if the phy-handle property exists - bail if it does */ rv = prom_getprop(node, "phy-handle", prop, sizeof(prop)); - if (!rv) + if (rv <= 0) return; /*
prom_getprop() can return PROM_ERROR. Binary operator can not identify it. Signed-off-by: Peiwei Hu <jlu.hpw@foxmail.com> --- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)