From patchwork Wed Dec 6 21:11:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 845357 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysWhZ6DFvz9s74 for ; Thu, 7 Dec 2017 08:19:26 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysWhZ53vVzF0Gy for ; Thu, 7 Dec 2017 08:19:26 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.3; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysWf52g5FzDrbq for ; Thu, 7 Dec 2017 08:17:16 +1100 (AEDT) Received: from [192.168.1.3] ([77.182.86.166]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MHGJ1-1eJ8Ts1KvT-00E5YU; Wed, 06 Dec 2017 22:11:51 +0100 Subject: [PATCH 1/3] tty/serial/ucc_uart: Delete an error message for a failed memory allocation in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: Date: Wed, 6 Dec 2017 22:11:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:2RSq5Or7dlejv7tHyaxIPj5KZDmYjU71nahW2N9q/fPMEubu6yw f3p7RobvY76tgEgbkp9tRN+kSZQrFNWsObcSW+ABKk7urG48aXpk7/UME842ZfTWuzaWqrJ JY32dv6S66MfUry9fI8Kku7os0fQB6bYpS+fpxUdBe4eJuyjKayUChFs+JJ70zB8lVhKjBb /KaHErokrQdZyzZGls6Uw== X-UI-Out-Filterresults: notjunk:1; V01:K0:WbjG8SDkgGI=:doTEQNJd20t2HgTMjJVQ6J 08N6nQoyJwwRnqrePsqyywOFV6a/e07A9fMuHTklNZH8BD4wu4UhVDA0YgkH7uvIvT6f8rme4 C0n8PesTu7XYoFbLm0ui60PPzingp5q/ZnQMsCqb85ub2r9LUgWZ7p9HM92vgzGHR0ARNFwP7 9VrJY9qXad/GtTG1g+jcQHvpPZ3ZorooqsKwWR6hqi4y3WfNaiQRDrdST/hFZF85yxEjTuczQ d/VpRmpGobhONY9aTKndYpXzu+HG8YY8yBGZnU0BQkd2I/w2hF45/0p//VAyGiW2J8EKCdUSM 38DXmvO8Sl/o7oX5Ot47QJlKnLeszM9Cwh0oyTar/vnDzBRhHfRjdAUgpTRpjadwntXELdI9O 8E0py6A6FRX4ZhC4LwoZ8Vn/77IT4W7qnBHpS9aNraWxRlDMgiii488dH4jzvxnlTzRpiMZz/ +VcgAw9t6O4H/BPYb5Yj/dxRGScyCO36p+X0AUNpQCWTW2Twrb1B7eO6aClYOq7sCILHAWdXA oSIfB/RRQXSvWM3JzwnCp1Y+A0x1nRajEXjBzgXfrKyoykgfXmtvZlH1aORg+IVqd1OCTi4GL AnU+l7NPR4Pff2O9umsJhpXB6Fr6qXaNVxP5aGhDeE4js5VLCsYmdAwWElla8y8m3dj9BGHZf kCkq50wxH0yPxU6dDEK/OnI8Zi2IjppfQ1xHSP1FkzINc2rytafqLHfghdZQQJKEpbX5vcxwk 5J1buEPFytHx+ySnWfvm7OM+Yt44QqVCCWrP4YXJ8ztjwUUyG1tvZU7IIZPQFvvVut/gDtl6q B9BUKQ8Gl41tx8jPilAA2LxFBQZbbh2l2kzFmZCFTtWRsvs0Mvt6sB7uZUBJhwoK7jtJuU7 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 6 Dec 2017 21:41:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 2b6376e6e5ad..48364f0eba72 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1254,10 +1254,8 @@ static int ucc_uart_probe(struct platform_device *ofdev) } qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); - if (!qe_port) { - dev_err(&ofdev->dev, "can't allocate QE port structure\n"); + if (!qe_port) return -ENOMEM; - } /* Search for IRQ and mapbase */ ret = of_address_to_resource(np, 0, &res);