From patchwork Fri Jan 20 18:28:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 717882 X-Patchwork-Delegate: paulus@samba.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v4qB96nz3z9sCX for ; Sat, 21 Jan 2017 05:34:41 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3v4qB95lRLzDr3S for ; Sat, 21 Jan 2017 05:34:41 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v4q4V2NFhzDrQq for ; Sat, 21 Jan 2017 05:29:46 +1100 (AEDT) Received: from [192.168.1.2] ([77.182.231.71]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MZleQ-1covP43hiI-00LXkq; Fri, 20 Jan 2017 19:28:57 +0100 Subject: [PATCH 10/11] KVM: PPC: e500: Use kcalloc() in e500_mmu_host_init() To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Alexander Graf , Benjamin Herrenschmidt , Michael Ellerman , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: From: SF Markus Elfring Message-ID: Date: Fri, 20 Jan 2017 19:28:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:ZwhpQLRhUc0oXMfS6OGKVVzXsndPNC7uPprIenO44GJw/MrzEo2 cyPKQ8mHiufIgh5HSjcigS4nWucrJS13y0eKBVb/vbM9mbnrcZkRljCdsy58lbF8PoPq/t1 OBfQQ9o/FezpNrQ9af3C1LS7dKMpumlkyV95whI4RIPZBIXKY2W9CAVmwVptdPr+f3vY9ay v4jYXA8N6kyFQUY/F5wDg== X-UI-Out-Filterresults: notjunk:1; V01:K0:QKmKZkkWVX8=:QFXNc5sgJg7hSbZHOFVlVG aJHv4gMjM3NR+KvYYe5iumRW9vXuWZcBVbReiYeCsvxk6qHaIJ12VCLkKxJdvtOxXXP7vvEv8 oushHW4azR6Ho7u5RvHzY+qM57AqQWnfzd55SmdLXCaoJx4MPmBM7hmOjmWe0nLMQftGIKQvs 4BLXzxUToTtbRa7t7UN4BHGl/92JUj7aHuHymV9+GD5Nyc02Hmi2MfgnM9wGeIvqjnW9WoUBb rIhQVFEWLJD8hbsQWpV7DGzGzN78iYuZz+z7LCfM11qvVEFE4Ujhh0XeddVCuRHFISJP/Hinh Xvci8MGSHX3TQjMdX5tBlp9jFQwblNTd0Q03b3dqh1dvP9eLzYaCgi0trjSXZn8ZT0uhcHV5I F9G90lokMLAT1RPcWLIVhY/9v56TfOgBISFdj3zOalJRGXobKbUbMmG9WTRtn0Ce67Eb3YCAh HfCWhmxVJBp42c4mcPQYr4lzVROhclm8uDJWLJr32+HGbkaai+yXwehrKabFSWEXPNyYS2+CC PCaQw5f20Wd38a22MM6GQVXzl8ljFpnlWQBDZ/uCXF+1vZV9Jtd61AYDi8kxBuGmDohqEGb0G LbTHb1qBc7n9yh5HfsxEes9rxKbHcjl11pRslhTHGa7Ovwchu/+jC4kXx9badu/gxx4HhXKMG jNnSrNP2K7Rhmb2T3RdS4M1GqdriA5FVlls7ehrV3kVoz2lH1eh2GKm+wINP4ZNhuVrC1UR6H izsaKARs1SXWOfGJopogXtEuegVl/CMxlUVxvamnW5DHaDO5sO9uRLBiIU7iGv9MtSdtHUslk S2h85de X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Fri, 20 Jan 2017 16:30:18 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/kvm/e500_mmu_host.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c index b0333cc737dd..a1af2f445988 100644 --- a/arch/powerpc/kvm/e500_mmu_host.c +++ b/arch/powerpc/kvm/e500_mmu_host.c @@ -797,9 +797,8 @@ int e500_mmu_host_init(struct kvmppc_vcpu_e500 *vcpu_e500) host_tlb_params[0].sets = host_tlb_params[0].entries / host_tlb_params[0].ways; host_tlb_params[1].sets = 1; - - vcpu_e500->h2g_tlb1_rmap = kzalloc(sizeof(unsigned int) * - host_tlb_params[1].entries, + vcpu_e500->h2g_tlb1_rmap = kcalloc(host_tlb_params[1].entries, + sizeof(*vcpu_e500->h2g_tlb1_rmap), GFP_KERNEL); if (!vcpu_e500->h2g_tlb1_rmap) return -EINVAL;