From patchwork Mon Aug 7 10:52:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 798575 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xQvXx5mGjz9t1t for ; Mon, 7 Aug 2017 20:54:09 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xQvXx4tV0zDr5T for ; Mon, 7 Aug 2017 20:54:09 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xQvWk2Rw4zDqjB for ; Mon, 7 Aug 2017 20:53:05 +1000 (AEST) Received: from [192.168.1.2] ([78.48.119.17]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M7scS-1dRYdS2TYm-00vNIu; Mon, 07 Aug 2017 12:52:14 +0200 To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Geoff Levand , Michael Ellerman , Paul Mackerras From: SF Markus Elfring Subject: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() Message-ID: Date: Mon, 7 Aug 2017 12:52:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:HOjOMlaMHHqOEWJFLi3uuhKpXq7WjWv3L74Z6Jv0/YBP/GgNzX3 X56nHj2/0jKM70cOCoCW62iZGyFDMdGqXqjIPxVfFQpk4a2Dy1f68sLwEDbOGTZmv1KSWok cg6jYqUKZ4hcY4N9XD2kUR1l/hWnvJ5mTqjg9cV0qm8Esct1CDmPO7Fv9XXgjKHeDgLXPk6 clSVX1HtGjF7FenikWp7A== X-UI-Out-Filterresults: notjunk:1; V01:K0:MmWAjGNguJc=:xwXrvHGe4BTU3ltaGwyTgF hsC3TY58JixLc+7QCki+JcjFtPUP+KC997W6S+OXDYWE6Y37Mh+JOtrArH60cN3GVIu0oWjMp qTJwkkgmmoylVOz010XBNf0cher91f2UlAmonuX5RuykVXAKQd0pRAYc65e2XplE6U+AR1ISD 4IHq6s0+jTEejc1efy7xh4YCI8wFmK2EBJLjFoO1AB8pe9iTNG51ro9y83zfgHZbEdtv3iCle RgrrFG1Ytpem6nUsUWs5C7vO3pgVy+jC3hGW76He0c25hGlnwgr+v4vyoljwjm1eb46xaR1IE vyEHziRFUzDaM6Ttk3qmNPgE/q34T2vxwsZRf+L+a7iIyHCyT8GMyUZu+JxSCiTPLhP1+kRhI om8aetzO6TqhCNKV9mcz5qJ+HwccHmibQsSfwHTi8UrYHknmlZ8OIVGFgMe94eZCl7+fRNrE8 tZpJ5D0C1Aeylnt6zhnjm15C3hblzcIPESI1fOeQygxW9hIc/sgaXOLa15hXKrAt92/8rqerx u8vO3NBwQk7WfxbqJwFzihTOfqsHXkIMErTA4WCfmAMeunGceUxhXEpBM3giFsyDJe0Qbjvpt h9w14rvopOTve6/0jBGeiklfVaXk9kno+T3XCpmESNb2pyWDVpfko2Ketar6POCyF0+4OT6lS zKDhcI7p5CnTE7ZIMyvhLCkhBt+XL1nlNnYjaQg6Iyzk/+a/CwgPXmjKEZejQwZ4DTrS+plPD wa0KPyPpGVPnKh7cAK0dZOjLgQo45QicyZLNQzHUf54Rx2I0+xdcNrH98g62Ni5beUacY2Oa2 Qp4bb1Wbren+56pjN8LKn5Z5LtkNVyaS4aFYYBOUlJruRMMWvU= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Mon, 7 Aug 2017 12:37:01 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/block/ps3vram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index e0e81cacd781..ba97d037279e 100644 --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -409,10 +409,8 @@ static int ps3vram_cache_init(struct ps3_system_bus_device *dev) priv->cache.page_size = CACHE_PAGE_SIZE; priv->cache.tags = kzalloc(sizeof(struct ps3vram_tag) * CACHE_PAGE_COUNT, GFP_KERNEL); - if (priv->cache.tags == NULL) { - dev_err(&dev->core, "Could not allocate cache tags\n"); + if (!priv->cache.tags) return -ENOMEM; - } dev_info(&dev->core, "Created ram cache: %d entries, %d KiB each\n", CACHE_PAGE_COUNT, CACHE_PAGE_SIZE / 1024);