From patchwork Thu Jan 19 17:03:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 717250 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v49VF5ZMMz9sxN for ; Fri, 20 Jan 2017 04:16:21 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3v49VF4fkLzDqSS for ; Fri, 20 Jan 2017 04:16:21 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v49Dg34Y8zDqQH for ; Fri, 20 Jan 2017 04:04:35 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.224.32]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MN4Kq-1caqm93w1A-006bgS; Thu, 19 Jan 2017 18:04:02 +0100 Subject: [PATCH 7/8] powerpc/nvram: Improve size determinations in three functions To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Daniel Axtens , Geliang Tang , Michael Ellerman , Nathan Fontenot , Pan Xinhui , Paul Gortmaker , Paul Mackerras References: <53545d97-6ed5-ff17-384f-82e72b3592f9@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Thu, 19 Jan 2017 18:03:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <53545d97-6ed5-ff17-384f-82e72b3592f9@users.sourceforge.net> X-Provags-ID: V03:K0:hXqHRF7irrV3ERxARLvOV1hn2+hfK0yVmx7BZ4SoUmejrdFRoZO GKyV4hHoKRvp/VhwWJWjvVu4lra6nBhzVb7H/xv/5BI1Y215DItB/8w/uh8ZDIXGhoSjlIp 8hTjtrvrJDR4zcYZpqeRe2qSTv4AGwYJkGr95TZNcTFNI5ErwMV3vV5HwjpoA+BQMRpY9dx Ty7+tTAn6oVAp9TLhw7LA== X-UI-Out-Filterresults: notjunk:1; V01:K0:TZMbhJOB/Wc=:jETaJhQle64rZkPVMudGIN 3G+t8+AAn4kvXoF7Usm/aYh1feVQm8FmikvVLxpOjey6FyYdUjCNbsqdqPg2yuZfZWXTwHhs5 p+uwtUg8RyYCfzzE/eYKNiMe9UfN6U67/aOdLQq839jVZT3G6tvebdys44LM6B3KFeGGqVtJA zVCI4ddFRqdEJLpEyPNF8a9hx2IAFGPIkyPOenqbG82zCChHtY1HSchEsrlKwW1MR0Hcyb7zt lQZU3Cv2cnOYZP6gwmZiwJajn/ghHWttMcz857+WgWmdaYI2MRitdkEzEklRTZFmHrNJ/YzwE oLP9LXz2j5g+v9rHIOk93hnCKzwq24/QIgkemq8fPZ2gdLKHCukntVEv5rXRaEJbjCPTF9yPd aV5r0ms7Mebi5Y9uNvLY8qsYWbCDVDjeKbJV8qQUVxWvL8+uAdQTw6OnRluAbeGVm35nCkJuU TaiTUWjDBg+FNW4RxuPWDQO4siXGnp7ouY8Yvzn3/KJWGmiBCoiHfPMyAKZO3eJSZedO47/KV v54j09eYV7ovz7yHpd3jm5Quvwy4uojmc+zrApil4y7hB5pHBuW8oSIZ7JDDmytBSO/Um6Sib MORu9GFDPCU5Fr9LJ6I0NrwNIUvJhZhKu9GSYxEZY3MaEoTQ0BbHRMa58CaLKkfE6fV/Wr7z5 ZVYRMLor21jmMRGVjx53vvi4LvFiYmXcrs9cU2pKtSkSsisOJQDiTOpyBChtl8YSFqMTjaLST /XjS2F2pHca+fn6mRbDCdaDH2dTcmK+24rszeRjPbWeEazkIOmnqHVzxIrc710ZIEgOuZSqAh vnzSfjN X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 19 Jan 2017 17:15:30 +0100 Replace the specification of data structures by references for local variables as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- arch/powerpc/kernel/nvram_64.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c index 7af1baaaf01b..ed54147e3c60 100644 --- a/arch/powerpc/kernel/nvram_64.c +++ b/arch/powerpc/kernel/nvram_64.c @@ -207,8 +207,7 @@ int nvram_write_os_partition(struct nvram_os_partition *part, tmp_index = part->index; - rc = ppc_md.nvram_write((char *)&info, sizeof(struct err_log_info), - &tmp_index); + rc = ppc_md.nvram_write((char *)&info, sizeof(info), &tmp_index); if (rc <= 0) { pr_err("%s: Failed nvram_write (%d)\n", __func__, rc); return rc; @@ -244,9 +243,7 @@ int nvram_read_partition(struct nvram_os_partition *part, char *buff, tmp_index = part->index; if (part->os_partition) { - rc = ppc_md.nvram_read((char *)&info, - sizeof(struct err_log_info), - &tmp_index); + rc = ppc_md.nvram_read((char *)&info, sizeof(info), &tmp_index); if (rc <= 0) { pr_err("%s: Failed nvram_read (%d)\n", __func__, rc); return rc; @@ -1175,7 +1172,7 @@ int __init nvram_scan_partitions(void) "detected: 0-length partition\n"); goto out; } - tmp_part = kmalloc(sizeof(struct nvram_partition), GFP_KERNEL); + tmp_part = kmalloc(sizeof(*tmp_part), GFP_KERNEL); err = -ENOMEM; if (!tmp_part) goto out;