From patchwork Wed Dec 13 17:33:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 848068 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yxkVh1vHmz9s83 for ; Thu, 14 Dec 2017 04:40:28 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3yxkVh0NCMzDrqJ for ; Thu, 14 Dec 2017 04:40:28 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.4; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yxkMN4fM8zDqnC for ; Thu, 14 Dec 2017 04:34:08 +1100 (AEDT) Received: from [192.168.1.3] ([77.181.208.154]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lcxjk-1epg1X2PU8-00iAr5; Wed, 13 Dec 2017 18:33:35 +0100 Subject: [PATCH 1/3] soc/fsl/qe: Delete an error message for a failed memory allocation in three functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Li Yang , Qiang Zhao References: <07738369-a787-98b4-41a5-71b7d630c356@users.sourceforge.net> Message-ID: Date: Wed, 13 Dec 2017 18:33:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <07738369-a787-98b4-41a5-71b7d630c356@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:+UUx2aMua3OVU+bRiVdyZvnE9KU2pIQY4rWPTlGxlnMXfb66uwc BBhne9TjLeOWIhZLoD7qDtnAiLm8tk9kotV5Gafd5GSfLAWyhohGtTEKvvoMW4JfcbzZpmL 4cZajPtHXbm6Ap6BNIl7tFnguCnyDClWjnDdNNJxTmcFioBZLQC+HgVnIra8mEgRQ8S5Zws PawOy8GYNfCNcgxLvZfqg== X-UI-Out-Filterresults: notjunk:1; V01:K0:ILAAA5BwZr4=:689vnfhiep0ATtxZBvrI5w nedi6XYI3C1k1wP2BoyJpg7EgcbjSXAu+roO3rtlIZwrb1f6PGNSIKDaAWZbyvipASge8WSlr voZWW7BuznI0WPTVH2XBcZBepKn5x5OuRDAo/pLoskHM6xjkCWIS8wsdOPdtJHqpYkGx7mMk2 cDzX9JxyDuyNmnSXbq2gV3Z6Fw2c/fTcMojbUxpSbA7a8f6cb9Ab4GFROpenPftAtHuwmAAn5 ADHmgAlgUnnXyLfGjGN/5j6Hy8dBWwyo/gXCpJZBn7nW9E/sT88JnBiLH+Fkh11nzqBOBwNlO 15qmTTRRJr8IzBE8tZp57dMOfyBoOQoy56L1IMsX2OtuoNusgD8OwxUOyVCrfAQRqOj81+tgK fnIJtG3NSFFSxksdysnxVDNXFYPN+5Eo8MRdj5ZDtroeK4Lybxg2oOJzjcUgtxrPn86EEk5XV cwjY3JSzS+WDDJVEh7Ug1LNACVxmjrmm7Tj3ABQogmsAEySrvK2qvJlWPN2fA3y+iR3eCH/pY pK70RPX8LOq71NDqPgNco7mMJbiaB9wzWzIk2Hz6M/dIF6TYZkmtg6aXKyc2oQrJyhPnVSofw PZahVy7vvMffmsG6npctghf4ah++LOED+ufKuW1Lr/ty0vzABGQ9evzADWID7cfN3kV5MiX67 xxfOnkhQNnQ9JI00RB20H7OYrUdgtXxt5AupaJsgEQBwp2vL4lSrt3pDEz5Aax2uaRVtWQ5Nu dynpLzKGpYB3jthSqZh4eyg8QS9ej3UB273oLB7kgKNV2NIb4rDv8OxqalnQMz/xWgvE7965S rJcYnq11/vZCe6pI+4iuEyDFwew5lcTsXIvqrlvV3xSoduULOc= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 13 Dec 2017 17:45:23 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/soc/fsl/qe/gpio.c | 4 +--- drivers/soc/fsl/qe/ucc_fast.c | 5 +---- drivers/soc/fsl/qe/ucc_slow.c | 5 +---- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c index 3b27075c21a7..9239cf176e67 100644 --- a/drivers/soc/fsl/qe/gpio.c +++ b/drivers/soc/fsl/qe/gpio.c @@ -143,10 +143,8 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) unsigned long flags; qe_pin = kzalloc(sizeof(*qe_pin), GFP_KERNEL); - if (!qe_pin) { - pr_debug("%s: can't allocate memory\n", __func__); + if (!qe_pin) return ERR_PTR(-ENOMEM); - } err = of_get_gpio(np, index); if (err < 0) diff --git a/drivers/soc/fsl/qe/ucc_fast.c b/drivers/soc/fsl/qe/ucc_fast.c index 83d8d16e3a69..59b68bf4aebb 100644 --- a/drivers/soc/fsl/qe/ucc_fast.c +++ b/drivers/soc/fsl/qe/ucc_fast.c @@ -195,11 +195,8 @@ int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** ucc } uccf = kzalloc(sizeof(struct ucc_fast_private), GFP_KERNEL); - if (!uccf) { - printk(KERN_ERR "%s: Cannot allocate private data\n", - __func__); + if (!uccf) return -ENOMEM; - } /* Fill fast UCC structure */ uccf->uf_info = uf_info; diff --git a/drivers/soc/fsl/qe/ucc_slow.c b/drivers/soc/fsl/qe/ucc_slow.c index 9334bdbd9b30..fc91412e2300 100644 --- a/drivers/soc/fsl/qe/ucc_slow.c +++ b/drivers/soc/fsl/qe/ucc_slow.c @@ -153,11 +153,8 @@ int ucc_slow_init(struct ucc_slow_info * us_info, struct ucc_slow_private ** ucc } uccs = kzalloc(sizeof(struct ucc_slow_private), GFP_KERNEL); - if (!uccs) { - printk(KERN_ERR "%s: Cannot allocate private data\n", - __func__); + if (!uccs) return -ENOMEM; - } /* Fill slow UCC structure */ uccs->us_info = us_info;