From patchwork Wed Sep 15 12:56:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 1528365 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H8gvx5H7kz9sPf for ; Wed, 15 Sep 2021 23:26:05 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H8gvx4WfNz2yLv for ; Wed, 15 Sep 2021 23:26:05 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux-m68k.org (client-ip=195.130.132.45; helo=newton.telenet-ops.be; envelope-from=geert@linux-m68k.org; receiver=) X-Greylist: delayed 308 seconds by postgrey-1.36 at boromir; Wed, 15 Sep 2021 23:25:44 AEST Received: from newton.telenet-ops.be (newton.telenet-ops.be [195.130.132.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4H8gvX4sh3z2xtd for ; Wed, 15 Sep 2021 23:25:43 +1000 (AEST) Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by newton.telenet-ops.be (Postfix) with ESMTPS id 4H8gnK2yjtzMrGrB for ; Wed, 15 Sep 2021 15:20:21 +0200 (CEST) Received: from ramsan.of.borg ([84.195.186.194]) by albert.telenet-ops.be with bizsmtp id uDLH2500s4C55Sk06DLHoU; Wed, 15 Sep 2021 15:20:20 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mQUnf-004eT9-TO; Wed, 15 Sep 2021 15:18:07 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1mQUT7-002gSI-H7; Wed, 15 Sep 2021 14:56:53 +0200 From: Geert Uytterhoeven To: Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , Shawn Guo , Li Yang , Scott Wood Subject: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing Date: Wed, 15 Sep 2021 14:56:52 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") added compile-test support to the Freescale 16550 driver. However, as SERIAL_8250_FSL is an invisible symbol, merely enabling COMPILE_TEST now enables this driver. Fix this by making SERIAL_8250_FSL visible. Tighten the dependencies to prevent asking the user about this driver when configuring a kernel without appropriate Freescale SoC or ACPI support. Fixes: b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") Signed-off-by: Geert Uytterhoeven --- Yes, it's ugly, but I see no better solution. Do you? drivers/tty/serial/8250/Kconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 808268edd2e82a45..a2978b31144e94f2 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -361,9 +361,13 @@ config SERIAL_8250_BCM2835AUX If unsure, say N. config SERIAL_8250_FSL - bool + bool "Freescale 16550-style UART support (8250 based driver)" depends on SERIAL_8250_CONSOLE - default PPC || ARM || ARM64 || COMPILE_TEST + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || (ARM64 && ACPI) || COMPILE_TEST + default FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || (ARM64 && ACPI) + help + Selecting this option will add support for the 16550-style serial + port hardware found on Freescale SoCs. config SERIAL_8250_DW tristate "Support for Synopsys DesignWare 8250 quirks"