From patchwork Fri Aug 20 02:34:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 1518892 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=lHDeTH5e; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GrQhp2FHRz9sWq for ; Fri, 20 Aug 2021 12:35:06 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GrQhp17TRz3cQ7 for ; Fri, 20 Aug 2021 12:35:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=lHDeTH5e; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::f35; helo=mail-qv1-xf35.google.com; envelope-from=cgel.zte@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=lHDeTH5e; dkim-atps=neutral Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GrQh833R1z3bTV for ; Fri, 20 Aug 2021 12:34:30 +1000 (AEST) Received: by mail-qv1-xf35.google.com with SMTP id g11so4798885qvd.2 for ; Thu, 19 Aug 2021 19:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoGBCWp3KCNfgB/Df5rElpIhp6P6dUadsEIrn/tjMyk=; b=lHDeTH5eYqmuMWehbWpNCnLy2x0qltq/wnwxqkp574COOjpeXYoxZVWThj7NyFE4Hi l/CnAimflK3MxW5xhT4W8ka6ZLHUaDWQzpkFPzTpzq3Og5s6yvjiG8zfsBaO/jgD4YGO bTnRSmIAKyJZMc5pUS4M2QvBR3CpGElgz8DMmvu6ifKoqlKVCpzNNafrJgsxgUo2kQUG a08TX9h1Kl0IOdPoAgesC+DBRz1YaJfYqE7qbb4vKSDkqtDMMgaqa6fGRpB9wFvFkNsh vUQZUBeAwGQnBdpkhEsSP5WxmfJXE8fi9YY5Qa+bEoHeN7heCyMtez5XMOojON14pFip fAWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoGBCWp3KCNfgB/Df5rElpIhp6P6dUadsEIrn/tjMyk=; b=GM7QQV9DEYI3ry5QU3iJHFjSEVPYDlOxzTUAl65YPQp1QJDKmabHiE2sVAZZNWPAng 4RHvM/STiDJ7JCAfqHZDwYGPbIu6Cp/8sqbpcqME+4rgrgR26t4WmGOsW4JHhCIB86iV nulrLUsgnpb7SFs9BH6j93UrZEY/g45dRoN79AIn+hAKAmqLbl6ZY7DjucQg7NHlKia5 lTJlHO7hEZERnfT2gut46ZyQ2s1NYTQPRQmFNwP2n3FOp1z4fgbz/D25GOooZHGJCMtz dzUsj6+g07iNHlS5yJqPg8/0SMCXHejMGijVy+F4Z7VRYldRgPewpz5MOaPqkvpfSDLO 8c7g== X-Gm-Message-State: AOAM531ti3oTKFYbLsmwa1JhRhkD6lLBcykfJJJClcPGeLaXFilnzS1q FirPNzOLUx5Kpm3aAWa00r0= X-Google-Smtp-Source: ABdhPJzYzgrCRZIg+O/2IZU7ylfpuT40S9ORMT3V/sxyKAAUeNrRmqvLLZ+J+8sSB2r4iqlr4XJ2AQ== X-Received: by 2002:ad4:54f2:: with SMTP id k18mr17878753qvx.24.1629426866086; Thu, 19 Aug 2021 19:34:26 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id r18sm2119277qtm.96.2021.08.19.19.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 19:34:25 -0700 (PDT) From: jing yangyang X-Google-Original-From: jing yangyang To: Benjamin Herrenschmidt Subject: [PATCH linux-next] macintosh: fix warning comparing pointer to 0 Date: Thu, 19 Aug 2021 19:34:14 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zeal Robot , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, jing yangyang Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Fix the following coccicheck warning: ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0 Reported-by: Zeal Robot Signed-off-by: jing yangyang --- drivers/macintosh/windfarm_pm91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c index 3f346af..568f8a2 100644 --- a/drivers/macintosh/windfarm_pm91.c +++ b/drivers/macintosh/windfarm_pm91.c @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void) /* First, locate the PID params in SMU SBD */ hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); - if (hdr == 0) { + if (!hdr) { printk(KERN_WARNING "windfarm: CPU PID fan config not found " "max fan speed\n"); goto fail;