| Message ID | b12b200502312957065a12f8d78e8d250c244d21.1629193159.git.jing.yangyang@zte.com.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [linux-next] macintosh: fix warning comparing pointer to 0 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 25 jobs. |
Le 20/08/2021 à 04:34, jing yangyang a écrit : > Fix the following coccicheck warning: > > ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0 > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: jing yangyang <cgel.zte@gmail.com>' != 'Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>' Please resend. Thanks Christophe > --- > drivers/macintosh/windfarm_pm91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c > index 3f346af..568f8a2 100644 > --- a/drivers/macintosh/windfarm_pm91.c > +++ b/drivers/macintosh/windfarm_pm91.c > @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void) > > /* First, locate the PID params in SMU SBD */ > hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); > - if (hdr == 0) { > + if (!hdr) { > printk(KERN_WARNING "windfarm: CPU PID fan config not found " > "max fan speed\n"); > goto fail;
diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c index 3f346af..568f8a2 100644 --- a/drivers/macintosh/windfarm_pm91.c +++ b/drivers/macintosh/windfarm_pm91.c @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void) /* First, locate the PID params in SMU SBD */ hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); - if (hdr == 0) { + if (!hdr) { printk(KERN_WARNING "windfarm: CPU PID fan config not found " "max fan speed\n"); goto fail;
Fix the following coccicheck warning: ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0 Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> --- drivers/macintosh/windfarm_pm91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)