diff mbox series

[8/9] macintosh/via-macii: Use the stack for reset request storage

Message ID a40f80dde90991757007b6962c386a208c970586.1593318192.git.fthain@telegraphics.com.au (mailing list archive)
State Accepted
Commit 046ace8256489f32740da07de55a913ca09ce5cf
Headers show
Series Macintosh II ADB driver fixes | expand

Commit Message

Finn Thain June 28, 2020, 4:23 a.m. UTC 
The adb_request struct can be stored on the stack because the request
is synchronous and is completed before the function returns.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 drivers/macintosh/via-macii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c
index 447273967e1e8..2f9be4ec7d345 100644
--- a/drivers/macintosh/via-macii.c
+++ b/drivers/macintosh/via-macii.c
@@ -313,7 +313,7 @@  static void macii_poll(void)
 /* Reset the bus */
 static int macii_reset_bus(void)
 {
-	static struct adb_request req;
+	struct adb_request req;
 
 	/* Command = 0, Address = ignored */
 	adb_request(&req, NULL, ADBREQ_NOSEND, 1, ADB_BUSRESET);