| Message ID | a3cfb270cd61cc3aacdf929e7739ae46dcff86bd.1444700960.git.sam.bobroff@au1.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, 2015-13-10 at 01:49:28 UTC, Sam bobroff wrote: > This patch provides individual system call numbers for the following > System V IPC system calls, on PowerPC, so that they do not need to be > multiplexed: > * semop, semget, semctl, semtimedop > * msgsnd, msgrcv, msgget, msgctl > * shmat, shmdt, shmget, shmctl You tested this right? :) Tell me about it. Also we could make these available to SPU programs, but I don't think there's any point, no one's going to do a libc update for that. cheers
On Tuesday 13 October 2015 20:38:42 Michael Ellerman wrote: > On Tue, 2015-13-10 at 01:49:28 UTC, Sam bobroff wrote: > > This patch provides individual system call numbers for the following > > System V IPC system calls, on PowerPC, so that they do not need to be > > multiplexed: > > * semop, semget, semctl, semtimedop > > * msgsnd, msgrcv, msgget, msgctl > > * shmat, shmdt, shmget, shmctl > > You tested this right? Tell me about it. > > Also we could make these available to SPU programs, but I don't think there's > any point, no one's going to do a libc update for that. > The existing sys_ipc is also in the list of exceptions that are not exported to the SPU. I don't remember what the reason for this is, but there probably was one. Arnd
On Tue, Oct 13, 2015 at 08:38:42PM +1100, Michael Ellerman wrote: > On Tue, 2015-13-10 at 01:49:28 UTC, Sam bobroff wrote: > > This patch provides individual system call numbers for the following > > System V IPC system calls, on PowerPC, so that they do not need to be > > multiplexed: > > * semop, semget, semctl, semtimedop > > * msgsnd, msgrcv, msgget, msgctl > > * shmat, shmdt, shmget, shmctl > > You tested this right? :) Tell me about it. Why yes I did: I have written a (fairly) trivial test program that calls each function in a way that doesn't fail (but that doesn't necessarily attempt to exercise the full functionality of it; my intent was primarily to validate the parameter passing part as that is where most of the code change is (on the glibc side)). I patched a local copy of glibc with the new kernel header and various tweaks to correctly format the parameter lists for the new calls (there is actually quite a lot of code in glibc around the IPC calls due to various compatibility issues). I could then build a full tool chain that supported the new calls. (This was a lot more extensive than the kernel patch but should be fairly close to what needs to go into glibc.) I used that tool chain to build a complete host system (using buildroot). Then I could run the following tests: * glibc: stock Host kernel: stock Result: success Notes: As expected, base case. * glibc: stock Host kernel: patched Result: success Notes: As expected, the old ipc() call still exists in the patched host. * glibc: patched Host kernel: stock Result: failure Notes: As expected, the test was run with a glibc that requires a patched kernel on an unpatched one so the syscalls are unknown. * glibc: patched Host kernel: patched Result: success Notes: As expected. (Also, a bit of debug in glibc shows the new system call paths being followed.) (I also re-ran the tests both for little-endian and big-endian hosts.) It would obviously be good to have someone else test this, but I can't see a way to make it easy to do. They would presumably have to go through all of the above, which seems too much to ask given how trivial the kernel side of the patch is. Still, it bothers me a bit so if there is any way please let me know. (I thought about writing some assembly to directly test the syscall numbers but all it would do is verify that the numbers are valid, which really isn't much of a test.) > Also we could make these available to SPU programs, but I don't think there's > any point, no one's going to do a libc update for that. > > cheers Cheers, Sam.
On Tue, 2015-13-10 at 01:49:28 UTC, Sam bobroff wrote: > This patch provides individual system call numbers for the following > System V IPC system calls, on PowerPC, so that they do not need to be > multiplexed: > * semop, semget, semctl, semtimedop > * msgsnd, msgrcv, msgget, msgctl > * shmat, shmdt, shmget, shmctl > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a34236155afb1cc41945e583 cheers
diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h index 126d0c4..c9e26cb 100644 --- a/arch/powerpc/include/asm/systbl.h +++ b/arch/powerpc/include/asm/systbl.h @@ -370,3 +370,15 @@ COMPAT_SYS(execveat) PPC64ONLY(switch_endian) SYSCALL_SPU(userfaultfd) SYSCALL_SPU(membarrier) +SYSCALL(semop) +SYSCALL(semget) +COMPAT_SYS(semctl) +COMPAT_SYS(semtimedop) +COMPAT_SYS(msgsnd) +COMPAT_SYS(msgrcv) +SYSCALL(msgget) +COMPAT_SYS(msgctl) +COMPAT_SYS(shmat) +SYSCALL(shmdt) +SYSCALL(shmget) +COMPAT_SYS(shmctl) diff --git a/arch/powerpc/include/asm/unistd.h b/arch/powerpc/include/asm/unistd.h index 13411be..6d8f802 100644 --- a/arch/powerpc/include/asm/unistd.h +++ b/arch/powerpc/include/asm/unistd.h @@ -12,7 +12,7 @@ #include <uapi/asm/unistd.h> -#define __NR_syscalls 366 +#define __NR_syscalls 378 #define __NR__exit __NR_exit #define NR_syscalls __NR_syscalls diff --git a/arch/powerpc/include/uapi/asm/unistd.h b/arch/powerpc/include/uapi/asm/unistd.h index 63377380..81579e9 100644 --- a/arch/powerpc/include/uapi/asm/unistd.h +++ b/arch/powerpc/include/uapi/asm/unistd.h @@ -388,5 +388,17 @@ #define __NR_switch_endian 363 #define __NR_userfaultfd 364 #define __NR_membarrier 365 +#define __NR_semop 366 +#define __NR_semget 367 +#define __NR_semctl 368 +#define __NR_semtimedop 369 +#define __NR_msgsnd 370 +#define __NR_msgrcv 371 +#define __NR_msgget 372 +#define __NR_msgctl 373 +#define __NR_shmat 374 +#define __NR_shmdt 375 +#define __NR_shmget 376 +#define __NR_shmctl 377 #endif /* _UAPI_ASM_POWERPC_UNISTD_H_ */
This patch provides individual system call numbers for the following System V IPC system calls, on PowerPC, so that they do not need to be multiplexed: * semop, semget, semctl, semtimedop * msgsnd, msgrcv, msgget, msgctl * shmat, shmdt, shmget, shmctl Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> --- v2: Rebased onto today's next-20151012. arch/powerpc/include/asm/systbl.h | 12 ++++++++++++ arch/powerpc/include/asm/unistd.h | 2 +- arch/powerpc/include/uapi/asm/unistd.h | 12 ++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-)