[v1,04/19] powerpc: Remove pte_ERROR()

Message ID	a13c503902d906815d1eaa252042150a9d8b3623.1694443576.git.christophe.leroy@csgroup.eu (mailing list archive)
State	Superseded
Headers	show Return-Path: <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com> Subject: [PATCH v1 04/19] powerpc: Remove pte_ERROR() Date: Mon, 11 Sep 2023 21:03:10 +0200 Message-ID: <a13c503902d906815d1eaa252042150a9d8b3623.1694443576.git.christophe.leroy@csgroup.eu> In-Reply-To: <cover.1694443576.git.christophe.leroy@csgroup.eu> References: <cover.1694443576.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>
Series	cleanup/refactor pgtable.h \| expand [v1,00/19] cleanup/refactor pgtable.h [v1,01/19] powerpc/8xx: Fix pte_access_permitted() for PAGE_NONE [v1,02/19] powerpc/64e: Fix wrong test in __ptep_test_and_clear_young() [v1,03/19] powerpc/40x: Remove stale PTE_ATOMIC_UPDATES macro [v1,04/19] powerpc: Remove pte_ERROR() [v1,05/19] powerpc: Deduplicate prototypes of ptep_set_access_flags() and phys_mem_access_prot() [v1,06/19] powerpc: Refactor update_mmu_cache_range() [v1,07/19] powerpc: Untangle fixmap.h and pgtable.h and mmu.h [v1,08/19] powerpc/nohash: Remove {pte/pmd}_protnone() [v1,09/19] powerpc/nohash: Refactor declaration of {map/unmap}_kernel_page() [v1,10/19] powerpc/nohash: Move 8xx version of pte_update() into pte-8xx.h [v1,11/19] powerpc/nohash: Replace #ifdef CONFIG_44x by IS_ENABLED(CONFIG_44x) in pgtable.h [v1,12/19] powerpc/nohash: Refactor pte_update() [v1,13/19] powerpc/nohash: Refactor checking of no-change in pte_update() [v1,14/19] powerpc/nohash: Deduplicate _PAGE_CHG_MASK [v1,15/19] powerpc/nohash: Deduplicate pte helpers [v1,16/19] powerpc/nohash: Refactor ptep_test_and_clear_young() [v1,17/19] powerpc/nohash: Deduplicate ptep_set_wrprotect() and ptep_get_and_clear() [v1,18/19] powerpc/nohash: Refactor pte_clear() [v1,19/19] powerpc/nohash: Refactor __ptep_set_access_flags()

Message ID

a13c503902d906815d1eaa252042150a9d8b3623.1694443576.git.christophe.leroy@csgroup.eu (mailing list archive)

State

Superseded

Headers

From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v1 04/19] powerpc: Remove pte_ERROR()
Date: Mon, 11 Sep 2023 21:03:10 +0200
Message-ID: 
 <a13c503902d906815d1eaa252042150a9d8b3623.1694443576.git.christophe.leroy@csgroup.eu>
In-Reply-To: <cover.1694443576.git.christophe.leroy@csgroup.eu>
References: <cover.1694443576.git.christophe.leroy@csgroup.eu>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org
Sender: "Linuxppc-dev"
 <linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>

Series

cleanup/refactor pgtable.h | expand

Commit Message

Christophe Leroy Sept. 11, 2023, 7:03 p.m. UTC

pte_ERROR() is used neither in powerpc code nor in common mm code.

Remove it.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 arch/powerpc/include/asm/book3s/32/pgtable.h | 3 ---
 arch/powerpc/include/asm/book3s/64/pgtable.h | 2 --
 arch/powerpc/include/asm/nohash/32/pgtable.h | 3 ---
 arch/powerpc/include/asm/nohash/64/pgtable.h | 2 --
 4 files changed, 10 deletions(-)

diff --git a/arch/powerpc/include/asm/book3s/32/pgtable.h b/arch/powerpc/include/asm/book3s/32/pgtable.h
index 9b13eb14e21b..543c3691839b 100644
--- a/arch/powerpc/include/asm/book3s/32/pgtable.h
+++ b/arch/powerpc/include/asm/book3s/32/pgtable.h
@@ -224,9 +224,6 @@  void unmap_kernel_page(unsigned long va);
 /* Bits to mask out from a PGD to get to the PUD page */
 #define PGD_MASKED_BITS		0
 
-#define pte_ERROR(e) \
-	pr_err("%s:%d: bad pte %llx.\n", __FILE__, __LINE__, \
-		(unsigned long long)pte_val(e))
 #define pgd_ERROR(e) \
 	pr_err("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pgd_val(e))
 /*
diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h
index 5c497c862d75..7c4ad1e03a49 100644
--- a/arch/powerpc/include/asm/book3s/64/pgtable.h
+++ b/arch/powerpc/include/asm/book3s/64/pgtable.h
@@ -1014,8 +1014,6 @@  static inline pmd_t *pud_pgtable(pud_t pud)
 	return (pmd_t *)__va(pud_val(pud) & ~PUD_MASKED_BITS);
 }
 
-#define pte_ERROR(e) \
-	pr_err("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, pte_val(e))
 #define pmd_ERROR(e) \
 	pr_err("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
 #define pud_ERROR(e) \
diff --git a/arch/powerpc/include/asm/nohash/32/pgtable.h b/arch/powerpc/include/asm/nohash/32/pgtable.h
index f99c53a5f184..868aecbec8d1 100644
--- a/arch/powerpc/include/asm/nohash/32/pgtable.h
+++ b/arch/powerpc/include/asm/nohash/32/pgtable.h
@@ -55,9 +55,6 @@  extern int icache_44x_need_flush;
 
 #define USER_PTRS_PER_PGD	(TASK_SIZE / PGDIR_SIZE)
 
-#define pte_ERROR(e) \
-	pr_err("%s:%d: bad pte %llx.\n", __FILE__, __LINE__, \
-		(unsigned long long)pte_val(e))
 #define pgd_ERROR(e) \
 	pr_err("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pgd_val(e))
 
diff --git a/arch/powerpc/include/asm/nohash/64/pgtable.h b/arch/powerpc/include/asm/nohash/64/pgtable.h
index eb6891e34cbd..8083c04a1e6d 100644
--- a/arch/powerpc/include/asm/nohash/64/pgtable.h
+++ b/arch/powerpc/include/asm/nohash/64/pgtable.h
@@ -269,8 +269,6 @@  static inline void __ptep_set_access_flags(struct vm_area_struct *vma,
 	flush_tlb_page(vma, address);
 }
 
-#define pte_ERROR(e) \
-	pr_err("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, pte_val(e))
 #define pmd_ERROR(e) \
 	pr_err("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
 #define pgd_ERROR(e) \

[v1,04/19] powerpc: Remove pte_ERROR()

Commit Message

Patch