From patchwork Mon Jan 18 07:23:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shaohui xie X-Patchwork-Id: 569485 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 56A44140328 for ; Mon, 18 Jan 2016 19:57:34 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3CD6F1A1911 for ; Mon, 18 Jan 2016 19:57:34 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0095.outbound.protection.outlook.com [157.56.112.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CF64A1A003F for ; Mon, 18 Jan 2016 19:56:33 +1100 (AEDT) Received: from VI1PR04MB1664.eurprd04.prod.outlook.com (10.164.85.14) by VI1PR04MB1664.eurprd04.prod.outlook.com (10.164.85.14) with Microsoft SMTP Server (TLS) id 15.1.361.13; Mon, 18 Jan 2016 07:23:27 +0000 Received: from VI1PR04MB1664.eurprd04.prod.outlook.com ([10.164.85.14]) by VI1PR04MB1664.eurprd04.prod.outlook.com ([10.164.85.14]) with mapi id 15.01.0361.006; Mon, 18 Jan 2016 07:23:27 +0000 From: Shaohui Xie To: Florian Fainelli , Sebastian Hesselbarth , Andrew Lunn , "shh.xie@gmail.com" Subject: RE: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR Thread-Topic: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR Thread-Index: AQHRTqYnpbLE2ruluUSUIoGEpBNv0J77OFIAgACrRXCAAU9LgIAAQ6aAgAMn5pA= Date: Mon, 18 Jan 2016 07:23:27 +0000 Message-ID: References: <1452759839-9874-1-git-send-email-shh.xie@gmail.com> <20160114164418.GD19773@lunn.ch> <56997951.90304@gmail.com> <5699B211.5070602@gmail.com> In-Reply-To: <5699B211.5070602@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shaohui.xie@nxp.com; x-originating-ip: [123.151.195.1] x-microsoft-exchange-diagnostics: 1; VI1PR04MB1664; 5:5sig0fk83bfH/kiskTIoggdiXOPKdI1n9F2zoeo1oEqcabeL00/HGgbPh3TwVqYo9t6gQV7PNbaOVfOmU/HiL1zSwppF0NQKgKXwIj95CDBrvH/5o/3ob0BxPawy5Z0eld/9BMyb+Ce8seCyAGI9jA==; 24:+1U6/uZUfaxJI0XArcgeK+8ECjYU5Fbz44Wqby14j2TGEXYmgFMmTkqMHYB3i0lZser01p1rNw5qnZwHU5hbnA5YGuZju9UKDYwjm54xivE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1664; x-ms-office365-filtering-correlation-id: 996db306-ab65-4da8-cb50-08d31fd84282 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046); SRVR:VI1PR04MB1664; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1664; x-forefront-prvs: 08252193F3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(4326007)(40100003)(81156007)(551934003)(50986999)(87936001)(66066001)(33656002)(54356999)(93886004)(2950100001)(2900100001)(101416001)(76176999)(122556002)(97736004)(86362001)(74316001)(10400500002)(5001960100002)(11100500001)(2906002)(6116002)(92566002)(19580395003)(76576001)(5004730100002)(586003)(2501003)(19580405001)(5001770100001)(3846002)(77096005)(1220700001)(105586002)(5002640100001)(5008740100001)(1096002)(106116001)(106356001)(5003600100002)(189998001)(102836003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1664; H:VI1PR04MB1664.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2016 07:23:27.7699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1664 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shaohui Xie , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" > > If you look at the list of possible values for "phy-mode" you'd see > > that none of it describes a PHY-to-PHY connection but all are for > > MAC-to-PHY connections. Also, names above suggest it already: MII is > > short for media _independent_ interface. > > > > I copy Andrew's concerns and think that neither 10000base-kx nor > > 10gbase-kr belong in the list of phy-mode properties. > > I concur with that as well, if the phy connection does not really matter here, > or does not seem like a good fit, maybe we should have a different property, or > just define the hardware interface a little differently? Right, 'phy-mode' is not a good fit for backplanes, how about a new property like 'backplane-mode' or something, like below: Thank you! Shaohui --- a/Documentation/devicetree/bindings/net/phy.txt +++ b/Documentation/devicetree/bindings/net/phy.txt @@ -33,6 +33,9 @@ Optional Properties: - broken-turn-around: If set, indicates the PHY device does not correctly release the turn around line low at the end of a MDIO transaction. +- backplane-mode: string, operation mode of the backplane PHY; + must be "1000base-kx" for 1000BASE-KX, or "10gbase-kr" for 10GBASE-KR. + Example: ethernet-phy@0 {