From patchwork Mon Jan 11 12:10:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 565779 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1D04F1402DE for ; Mon, 11 Jan 2016 23:12:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=RVspbodi; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id EC7C11A0DBE for ; Mon, 11 Jan 2016 23:12:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=RVspbodi; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8E0D41A0202 for ; Mon, 11 Jan 2016 23:11:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=RVspbodi; dkim-atps=neutral Received: by mail-oi0-x241.google.com with SMTP id e195so16801979oig.2 for ; Mon, 11 Jan 2016 04:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=KI7HrFE4uZwGc70WyS2NlmaL36qTfx9JAFvoIc0qLe0=; b=RVspbodiqG5/DZtPVx4YEGkBJJX4+Y4MzzDhAoShMDWXKEW0x8odNIqMRgRA1nSgdl u2ASLQh/V/CWhmxINQqguUqt53jDoClR2RdN/lCKzZQeC1XSUat2xATYRt76f4btNbua IIe0smGXTzu0CVofp8ZFrgHbL+vAnp0KOgh0Z0CuXK70WTiGPx+y4p+Ys/WZcgPbkbo7 Ito9GeZkVgGBjF+D9/h2B3A/3YuD5ACII/uC6b3iU0g1aeGFkIKQY5PpWC2ZuT+z19am rstr+x6dTfLlcdQMCd03PynuUmEr1OPfx6lQ5zHNkAGrxmyaVscWGXJGLcg7XQjk+sfM aGGQ== MIME-Version: 1.0 X-Received: by 10.202.73.69 with SMTP id w66mr87497667oia.85.1452514257098; Mon, 11 Jan 2016 04:10:57 -0800 (PST) Received: by 10.202.229.82 with HTTP; Mon, 11 Jan 2016 04:10:56 -0800 (PST) In-Reply-To: References: <5677107C.60904@maciej.szmigiero.name> Date: Mon, 11 Jan 2016 10:10:56 -0200 Message-ID: Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults From: Fabio Estevam To: "Maciej S. Szmigiero" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alsa-devel@alsa-project.org" , Xiubo Li , linux-kernel , Liam Girdwood , Timur Tabi , Nicolin Chen , Mark Brown , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam wrote: > This patch causes the following issue in linux-next: > > [ 2.526984] ------------[ cut here ]------------ > [ 2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755 > lockdep_trace_alloc+0xf4/0x124() > [ 2.540771] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [ 2.546175] Modules linked in: > [ 2.549447] CPU: 1 PID: 1 Comm: swapper/0 Not tainted > 4.4.0-rc8-next-20160111 #204 > [ 2.557021] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) > [ 2.563553] Backtrace: > [ 2.566040] [] (dump_backtrace) from [] > (show_stack+0x18/0x1c) > [ 2.573615] r6:00000ac3 r5:00000000 r4:00000000 r3:00000000 > [ 2.579362] [] (show_stack) from [] > (dump_stack+0x88/0xa4) > [ 2.586607] [] (dump_stack) from [] > (warn_slowpath_common+0x80/0xbc) > [ 2.594702] r5:c0071ed0 r4:ef055b90 > [ 2.598326] [] (warn_slowpath_common) from [] > (warn_slowpath_fmt+0x38/0x40) > [ 2.607028] r8:00000004 r7:00000004 r6:024080c0 r5:024080c0 r4:60000093 > [ 2.613829] [] (warn_slowpath_fmt) from [] > (lockdep_trace_alloc+0xf4/0x124) > [ 2.622532] r3:c09a1634 r2:c099dc0c > [ 2.626161] [] (lockdep_trace_alloc) from [] > (kmem_cache_alloc+0x30/0x174) > [ 2.634778] r4:ef001f00 r3:c0b02a88 > [ 2.638407] [] (kmem_cache_alloc) from [] > (regcache_rbtree_write+0x150/0x724) > [ 2.647283] r10:00000000 r9:00000010 r8:00000004 r7:00000004 > r6:0000002c r5:00000000 > [ 2.655203] r4:00000000 > [ 2.657767] [] (regcache_rbtree_write) from [] > (regcache_write+0x5c/0x64) This fixes the warning: --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -180,7 +180,6 @@ static const struct regmap_config fsl_ssi_regconfig = { .volatile_reg = fsl_ssi_volatile_reg, .precious_reg = fsl_ssi_precious_reg, .writeable_reg = fsl_ssi_writeable_reg, - .cache_type = REGCACHE_RBTREE, }; Is this the correct fix?