Message ID | CAN8TOE-fpTYj5Z5VW=MbH6epK9Ymc+=uQkh7V6=k=76_DjouPA@mail.gmail.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
On Thu, 2013-03-28 at 21:28 -0700, Brian Norris wrote: > On Wed, Mar 27, 2013 at 5:25 AM, Roy Zang <tie-fei.zang@freescale.com> wrote: > > memory is allocated by devm_kzalloc, so release it using > > devm_kfree() instead kfree(); > > You are correct that it should not be freed with kfree(). But the > correct solution is that it does not need to be freed (explicitly) at > all. That's the whole point of the managed allocators (i.e., > devm_kzalloc()). Try this patch instead. Totally untested here. Pushed to l2-mtd.git, thanks!
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c index f1f7f12..180bfa7 100644 --- a/drivers/mtd/nand/fsl_ifc_nand.c +++ b/drivers/mtd/nand/fsl_ifc_nand.c @@ -908,7 +908,6 @@ static int fsl_ifc_chip_remove(struct fsl_ifc_mtd *priv) ifc_nand_ctrl->chips[priv->bank] = NULL; dev_set_drvdata(priv->dev, NULL); - kfree(priv); return 0; }