Message ID | 922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On 3/31/16 4:25 AM, Naveen N. Rao wrote: > Building BPF samples is failing with the below error: > > samples/bpf/map_perf_test_user.c: In function ‘main’: > samples/bpf/map_perf_test_user.c:134:9: error: variable ‘r’ has > initializer but incomplete type > struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; > ^ > Fix this by including the necessary header file. > > Cc: Alexei Starovoitov <ast@fb.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > --- > samples/bpf/map_perf_test_user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c > index 95af56e..3147377 100644 > --- a/samples/bpf/map_perf_test_user.c > +++ b/samples/bpf/map_perf_test_user.c > @@ -17,6 +17,7 @@ > #include <linux/bpf.h> > #include <string.h> > #include <time.h> > +#include <sys/resource.h> > #include "libbpf.h" > #include "bpf_load.h" It's failing this way on powerpc? Odd. Such hidden header dependency was always puzzling to me. Anyway: Acked-by: Alexei Starovoitov <ast@kernel.org> I'm assuming you want this set to go via 'net' tree, so please resubmit with [PATCH net 1/4] subjects and cc netdev. Reviewing your other patches...
On 2016/03/31 10:43AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Building BPF samples is failing with the below error: > > > >samples/bpf/map_perf_test_user.c: In function ‘main’: > >samples/bpf/map_perf_test_user.c:134:9: error: variable ‘r’ has > >initializer but incomplete type > > struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; > > ^ > >Fix this by including the necessary header file. > > > >Cc: Alexei Starovoitov <ast@fb.com> > >Cc: David S. Miller <davem@davemloft.net> > >Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > >Cc: Michael Ellerman <mpe@ellerman.id.au> > >Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > >--- > > samples/bpf/map_perf_test_user.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c > >index 95af56e..3147377 100644 > >--- a/samples/bpf/map_perf_test_user.c > >+++ b/samples/bpf/map_perf_test_user.c > >@@ -17,6 +17,7 @@ > > #include <linux/bpf.h> > > #include <string.h> > > #include <time.h> > >+#include <sys/resource.h> > > #include "libbpf.h" > > #include "bpf_load.h" > > It's failing this way on powerpc? Odd. This fails for me on x86_64 too -- RHEL 7.1. > Such hidden header dependency was always puzzling to me. Anyway: > Acked-by: Alexei Starovoitov <ast@kernel.org> > > I'm assuming you want this set to go via 'net' tree, so please resubmit > with [PATCH net 1/4] subjects and cc netdev. Sure. > > Reviewing your other patches... Thanks for your review! - Naveen
On 3/31/16 11:46 AM, Naveen N. Rao wrote: >> It's failing this way on powerpc? Odd. > This fails for me on x86_64 too -- RHEL 7.1. indeed. fails on centos 7.1, whereas centos 6.7 is fine.
diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c index 95af56e..3147377 100644 --- a/samples/bpf/map_perf_test_user.c +++ b/samples/bpf/map_perf_test_user.c @@ -17,6 +17,7 @@ #include <linux/bpf.h> #include <string.h> #include <time.h> +#include <sys/resource.h> #include "libbpf.h" #include "bpf_load.h"
Building BPF samples is failing with the below error: samples/bpf/map_perf_test_user.c: In function ‘main’: samples/bpf/map_perf_test_user.c:134:9: error: variable ‘r’ has initializer but incomplete type struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; ^ samples/bpf/map_perf_test_user.c:134:21: error: ‘RLIM_INFINITY’ undeclared (first use in this function) struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; ^ samples/bpf/map_perf_test_user.c:134:21: note: each undeclared identifier is reported only once for each function it appears in samples/bpf/map_perf_test_user.c:134:9: warning: excess elements in struct initializer [enabled by default] struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; ^ samples/bpf/map_perf_test_user.c:134:9: warning: (near initialization for ‘r’) [enabled by default] samples/bpf/map_perf_test_user.c:134:9: warning: excess elements in struct initializer [enabled by default] samples/bpf/map_perf_test_user.c:134:9: warning: (near initialization for ‘r’) [enabled by default] samples/bpf/map_perf_test_user.c:134:16: error: storage size of ‘r’ isn’t known struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; ^ samples/bpf/map_perf_test_user.c:139:2: warning: implicit declaration of function ‘setrlimit’ [-Wimplicit-function-declaration] setrlimit(RLIMIT_MEMLOCK, &r); ^ samples/bpf/map_perf_test_user.c:139:12: error: ‘RLIMIT_MEMLOCK’ undeclared (first use in this function) setrlimit(RLIMIT_MEMLOCK, &r); ^ samples/bpf/map_perf_test_user.c:134:16: warning: unused variable ‘r’ [-Wunused-variable] struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY}; ^ make[2]: *** [samples/bpf/map_perf_test_user.o] Error 1 Fix this by including the necessary header file. Cc: Alexei Starovoitov <ast@fb.com> Cc: David S. Miller <davem@davemloft.net> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> --- samples/bpf/map_perf_test_user.c | 1 + 1 file changed, 1 insertion(+)