From patchwork Thu Jan 11 18:00:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 859222 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zHYcd5V6hz9ryQ for ; Fri, 12 Jan 2018 05:02:25 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zHYcd46B5zF0gF for ; Fri, 12 Jan 2018 05:02:25 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.3; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zHYZs5gQ1zF0dJ for ; Fri, 12 Jan 2018 05:00:53 +1100 (AEDT) Received: from [192.168.1.3] ([92.227.255.105]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MHdwC-1eancN0jca-003MPq; Thu, 11 Jan 2018 19:00:35 +0100 Subject: [PATCH 1/5] powerpc/4xx: Combine four seq_printf() calls into two in ocm_debugfs_show() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Rob Herring , Tyrel Datwyler References: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Message-ID: <90e9f81b-25ad-cf02-663c-50a9997d9d53@users.sourceforge.net> Date: Thu, 11 Jan 2018 19:00:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <2b9b4285-f1c0-5dc7-35c6-df901c9ca0eb@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:+kYZSVXMk1tj7XCllKmTfnWwx9D91EaB4oeOxD+O7lUDhutADC0 1FAxVlW8F2yHPe6QICguq8XdH9PMvniRejFVSWsJWmv0lT4+tibzXR0yaWJzPnRMJJNBcwV igBygQoOrDacNhkBa6uEKFpbFn8b8MFL0LZ/AGMIr5eEPqzhZNioEAN56KUC9k4O2iKKq3+ 3FH2O4ayb/WIOkw4RGJoQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Jrkm8Q/qUwo=:IFdDljf/O7oCzZsPZzFWbt OuMcZtgFQ8fx6tqidjuYDX3bvYZO/5w5JyXxPsMUjPbTZB1cuFC27r9x2YGt6oj3dNJL5RwXP 4MdT5qbM4Qcb9No0SfbiROZLJhQxUQ+6GosVNdRDbqnYQ8m/UV2H7BQgSi/wyth+69JVynb/C o8JK3k6/6SCWJbLpKFJZUTvV2OxzHqgkSLFBBzRMECUA2IaC6cd6YRRnPsrY6moG5gE912uXv rA9B6GlIzVl8e/aTYBHNx6vj7lgmQj9wrWmPmNTUdj9arRdL3Ke6OL6a9nn1BACyNpjL8upmN 0bmhYJNPjN8FSC5zP7nTgc5iD7HaFquZxUg1N40dCETV5mgYsvjDtihIvVqIpGJtrpzu2u2et BUjRa7hiv8f7oWtYys6Kf7nv9zSzsFqwraabuk9HCJPMcps9+2xo/Tnsm2PQuagQXm7sXVOrS q4HT2AS9NiCL0fRNSqm96NR5ehFBUuEKTZgprMauCJ64pwp9R+flFIS3JvHhQWEt45Oiob98l JEvduOjPNPvc2uKDZ4DDS/vsokJ7EHVLkWSs0nZNQ502yPjRQy5UuGIxRtfMIG4eiv1zGdlUF bw2nWZF6hAOx+pMiR2wgb7ZyKk+j4AdjeoRTkENNpNqEGUsyl8vwKBRtEG8P4LQhdRPeiFd/n uqy2Y9lhmYGP53Qtm4A6PEWvtFB1RPyfxu3RMONtuGI3ZrfAUw5/hOWJm9kZaZpWU6UgX2pYE gbONoEpCoM8ict1dVI+v6kNDHdaW6mIbb2Ami+M5dFD56rgQg7UoBhx/bgHzvCgxtUAO1pL2J bhb9Ppy9wkAXtzBCatKqLSJl3Nau0bb3QyJuNnYdttFmy0cL+4= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 11 Jan 2018 18:08:08 +0100 Some data were printed into a sequence by four separate function calls. Print the same data by two single function calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/4xx/ocm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c index 85d9e37f5ccb..5bc1baf809d1 100644 --- a/arch/powerpc/platforms/4xx/ocm.c +++ b/arch/powerpc/platforms/4xx/ocm.c @@ -245,9 +245,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v) seq_printf(m, "PhysAddr : 0x%llx\n", ocm->phys); seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal); seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal); - seq_printf(m, "MemTotal(C) : %d Bytes\n", ocm->c.memtotal); - - seq_printf(m, "\n"); + seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal); seq_printf(m, "NC.PhysAddr : 0x%llx\n", ocm->nc.phys); seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt); @@ -259,9 +257,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v) blk->size, blk->owner); } - seq_printf(m, "\n"); - - seq_printf(m, "C.PhysAddr : 0x%llx\n", ocm->c.phys); + seq_printf(m, "\nC.PhysAddr : 0x%llx\n", ocm->c.phys); seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt); seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal); seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree);