diff mbox series

[PowerPC,PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

Message ID 8e07238a-06c0-4913-aec8-824c626f7461@yahoo.com.au (mailing list archive)
State Not Applicable
Headers show
Series [PowerPC,PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29 | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 5 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 21 jobs.

Commit Message

Damien Stewart July 10, 2024, 3:08 a.m. UTC 
On 9/7/24 10:48 pm, Michael Ellerman wrote:
> Thanks.
>
> Which kernel is the bad log from? Just plain rc6 with no patches?

So, no, the bad log is actually from a patched kernel. I've attached the 
diff for clarity.

> What happened when you tried the patch from me? I think Christian called
> it vmlinux-6.10-17. Did you get any different output?
If I have the correct patch this one failed. Yes it was one called 
vmlinux-6.10-17. It reported a (failed?) interpret command returning -1. 
Internet seems lacking info on OF binary API, but plenty on user 
commands.  Christian released another after as vmlinux-6.10-18 with a 
working patch. Also included.
> Does anything appear before the "hash-mmu" lines? Those are from the
> kernel, we'd really like to see the output from firmware which runs
> before that.
>
> cheers

Sorry I managed to cut that off. The dmesg actually does the same. I've 
grabbed another log of both patches.
diff mbox series

Patch

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 462375b293e47..c94203ce65bb3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -81,7 +81,8 @@  EXPORT_SYMBOL_GPL(of_irq_find_parent);
 /*
  * These interrupt controllers abuse interrupt-map for unspeakable
  * reasons and rely on the core code to *ignore* it (the drivers do
- * their own parsing of the property).
+ * their own parsing of the property). The PAsemi entry covers a
+ * non-sensical interrupt-map that is better left ignored.
  *
  * If you think of adding to the list for something *new*, think
  * again. There is a high chance that you will be sent back to the
@@ -95,6 +96,7 @@  static const char * const of_irq_imap_abusers[] = {
 	"fsl,ls1043a-extirq",
 	"fsl,ls1088a-extirq",
 	"renesas,rza1-irqc",
+	"pasemi,rootbus",
 	NULL,
 };

@@ -293,20 +295,8 @@  int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
 			imaplen -= imap - oldimap;
 			pr_debug(" -> imaplen=%d\n", imaplen);
 		}
-		if (!match) {
-			if (intc) {
-				/*
-				 * The PASEMI Nemo is a known offender, so
-				 * let's only warn for anyone else.
-				 */
-				WARN(!IS_ENABLED(CONFIG_PPC_PASEMI),
-				     "%pOF interrupt-map failed, using interrupt-controller\n",
-				     ipar);
-				return 0;
-			}
-
+		if (!match)
 			goto fail;
-		}

 		/*
 		 * Successfully parsed an interrupt-map translation; copy new