From patchwork Wed Oct 18 19:21:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 827788 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yHMRV0RzFz9t6m for ; Thu, 19 Oct 2017 06:23:34 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3yHMRT6f2NzDrVZ for ; Thu, 19 Oct 2017 06:23:33 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=217.72.192.78; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yHMPq4kw4zDrRV for ; Thu, 19 Oct 2017 06:22:07 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.46.217]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MMn1H-1e9abz0DKJ-008c1U; Wed, 18 Oct 2017 21:21:40 +0200 Subject: [PATCH 1/5] powerpc-pseries: Delete five error messages for a failed memory allocation From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Alex Williamson , Alexey Kardashevskiy , Andrew Morton , Bart Van Assche , Benjamin Herrenschmidt , David Gibson , Doug Ledford , Greg Kroah-Hartman , Johan Hovold , Masahiro Yamada , Michael Ellerman , Nathan Fontenot , Paul Mackerras , Rob Herring , Sahil Mehta , Tyrel Datwyler References: <0d221be4-1402-0499-d95e-afa4a30e1f33@users.sourceforge.net> Message-ID: <8cdd700c-47d1-0819-a3d1-17f79db45f8c@users.sourceforge.net> Date: Wed, 18 Oct 2017 21:21:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0d221be4-1402-0499-d95e-afa4a30e1f33@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:ymPhddhkzMCGZJ8Tldz2lEkyVLftg+ZIlmL4uA8IXlc0d+7WCL5 ocNXJNYxD9LAY8zgt62TkZrrLKSEp5Z8qGLgLnQKDLsYKR794UjH3vosDRis2OHp4TiTQZj jJYj7ujEoxVNMY7ITWtIac722wU/7McrRngPpTMS6nB8CQPI5FwH2cIQef2+zTnZyCIFC7s VYENXCn92niZJVWNksEug== X-UI-Out-Filterresults: notjunk:1; V01:K0:zrYY8kdcL7Q=:XG/rVG0mpA/+erWOmEuhtA fVInjd7f5ep5+HdYlpZLSmSazDCssehiX4gDfdxYAHFtuBA/5frLkaX9Fj3sydwODElaylFbP a/1Jknw2nYlb70DId2WYfn4tqZIsA0T3m/p5Xg2+egxKDrgpgI4xM6WxJwvWZbeZkz9hab4hz OEGn6J8cAL8BJ78Dm57DhNP9qXzlRRP/oRJXIITdLSJUJYdcuVjDEBHs8Q+4nhJbjIoH2k5Mf AN5awB3USWsnJOHMsEFV6vYscgHUKR/SFdhI73bOVF5pI/Ly6H9wZmEHll63kErYL8WtHf89Y 9E9NLQSIV3Sf35AsK+lsoIOvpgQ+NN/MVvzDPSEHqvTWyZ8pukXYl7spTN3FN1bdA2b7+YIpY OGBt/RRrS7r/eJS8ODNR8I5WkM5RyrZIfaRDUjd6TEZWf/s3Dj6TMEJNsCFqUYUUZWsaZYFpO klqX2t4TQlqdQUHksLMW3LskH+qUfq2wcDM44QFc0hFz24R+fJWZibk8V0Y6lStcEgcsSxVfm SMp87dgL+C4jz7bgPIIuxJelKOw/CNBOBAsryWv8xIf6pnm0wOerAw+WMFazIphnVEoqjdhQ7 n5dRTQTcBtKJQWMJDIwX8HzEcYhoXteF5oEye+Toj5LJvBMa43cX5b7awf7h5Lc2fg+4wdAsX fgR/EVNg86Y7syLnmTLwgdjm/MPdmHP0qbAdiaYnqeVjaWjkbY3dQUtwZUdKGwkO8ym4OqARh 0eVZEIWczl3iJScLAIamybD9MbYCr8/9yer+y5JNpuIrzKeInBja/pWkGFn+epe7M8XSF34A0 3gNc7BZnqhDT7TlxTlouJcm/rnEKaErYe4HpEJc7SmBPlyArrI= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 18 Oct 2017 16:39:01 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/pseries/dtl.c | 5 +---- arch/powerpc/platforms/pseries/hvcserver.c | 2 -- arch/powerpc/platforms/pseries/iommu.c | 11 +++-------- arch/powerpc/platforms/pseries/vio.c | 4 +--- 4 files changed, 5 insertions(+), 17 deletions(-) diff --git a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/pseries/dtl.c index 18014cdeb590..467b9f578a7d 100644 --- a/arch/powerpc/platforms/pseries/dtl.c +++ b/arch/powerpc/platforms/pseries/dtl.c @@ -203,11 +203,8 @@ static int dtl_enable(struct dtl *dtl) n_entries = dtl_buf_entries; buf = kmem_cache_alloc_node(dtl_cache, GFP_KERNEL, cpu_to_node(dtl->cpu)); - if (!buf) { - printk(KERN_WARNING "%s: buffer alloc failed for cpu %d\n", - __func__, dtl->cpu); + if (!buf) return -ENOMEM; - } spin_lock(&dtl->lock); rc = -EBUSY; diff --git a/arch/powerpc/platforms/pseries/hvcserver.c b/arch/powerpc/platforms/pseries/hvcserver.c index 94a6e5612b0d..db2c20e65a58 100644 --- a/arch/powerpc/platforms/pseries/hvcserver.c +++ b/arch/powerpc/platforms/pseries/hvcserver.c @@ -177,8 +177,6 @@ int hvcs_get_partner_info(uint32_t unit_address, struct list_head *head, GFP_ATOMIC); if (!next_partner_info) { - printk(KERN_WARNING "HVCONSOLE: kmalloc() failed to" - " allocate partner info struct.\n"); hvcs_free_partner_info(head); return -ENOMEM; } diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c index 7c181467d0ad..c92822fdf269 100644 --- a/arch/powerpc/platforms/pseries/iommu.c +++ b/arch/powerpc/platforms/pseries/iommu.c @@ -1063,19 +1063,14 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn) } len = order_base_2(max_addr); win64 = kzalloc(sizeof(struct property), GFP_KERNEL); - if (!win64) { - dev_info(&dev->dev, - "couldn't allocate property for 64bit dma window\n"); + if (!win64) goto out_failed; - } + win64->name = kstrdup(DIRECT64_PROPNAME, GFP_KERNEL); win64->value = ddwprop = kmalloc(sizeof(*ddwprop), GFP_KERNEL); win64->length = sizeof(*ddwprop); - if (!win64->name || !win64->value) { - dev_info(&dev->dev, - "couldn't allocate property name and value\n"); + if (!win64->name || !win64->value) goto out_free_prop; - } ret = create_ddw(dev, ddw_avail, &create, page_shift, len); if (ret != 0) diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c index 12277bc9fd9e..74b919040e68 100644 --- a/arch/powerpc/platforms/pseries/vio.c +++ b/arch/powerpc/platforms/pseries/vio.c @@ -1386,10 +1386,8 @@ struct vio_dev *vio_register_device_node(struct device_node *of_node) /* allocate a vio_dev for this node */ viodev = kzalloc(sizeof(struct vio_dev), GFP_KERNEL); - if (viodev == NULL) { - pr_warn("%s: allocation failure for VIO device.\n", __func__); + if (!viodev) return NULL; - } /* we need the 'device_type' property, in order to match with drivers */ viodev->family = family;