| Message ID | 89ae94f722996b4ee7ef20d44cd7f5e2f0495c47.1724310149.git.zhengqi.arch@bytedance.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | introduce pte_offset_map_{ro|rw}_nolock() | expand |
On 22.08.24 09:13, Qi Zheng wrote: > In assert_pte_locked(), we just get the ptl and assert if it was already > held, so convert it to using pte_offset_map_ro_nolock(). > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> > --- > arch/powerpc/mm/pgtable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index 7316396e452d8..61df5aed79894 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr) > */ > if (pmd_none(*pmd)) > return; > - pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); > + pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl); > BUG_ON(!pte); > assert_spin_locked(ptl); > pte_unmap(pte); Acked-by: David Hildenbrand <david@redhat.com>
On 2024/8/22 15:13, Qi Zheng wrote: > In assert_pte_locked(), we just get the ptl and assert if it was already > held, so convert it to using pte_offset_map_ro_nolock(). > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> Reviewed-by: Muchun Song <muchun.song@linux.dev>
diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index 7316396e452d8..61df5aed79894 100644 --- a/arch/powerpc/mm/pgtable.c +++ b/arch/powerpc/mm/pgtable.c @@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr) */ if (pmd_none(*pmd)) return; - pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); + pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl); BUG_ON(!pte); assert_spin_locked(ptl); pte_unmap(pte);
In assert_pte_locked(), we just get the ptl and assert if it was already held, so convert it to using pte_offset_map_ro_nolock(). Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> --- arch/powerpc/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)