| Message ID | 8949eefb-30d3-3c51-4f03-4a3c6f1b15dc@web.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/pseries: Fixes for exception handling in pSeries_reconfig_add_node() | expand |
> Date: Tue, 21 Mar 2023 10:30:23 +0100 > > It can be determined in the implementation of the function > “pSeries_reconfig_add_node” that an error code would occasionally > be provided by a call of a function like pseries_of_derive_parent(). > This error indication was passed to an of_node_put() call according to > an attempt for exception handling so far. … I was notified also about the following adjustment. … * linuxppc-dev: [resent,v2,1/2] powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() - http://patchwork.ozlabs.org/project/linuxppc-dev/patch/f5ac19db-c7d5-9a94-aa37-9bb448fe665f@web.de/ - for: Linux PPC development was: New now: Changes Requested … It seems that I can not see so far why this status update happened for any reasons. Will further clarifications become helpful here? Regards, Markus
Le 03/10/2024 à 19:05, Markus Elfring a écrit : >> Date: Tue, 21 Mar 2023 10:30:23 +0100 >> >> It can be determined in the implementation of the function >> “pSeries_reconfig_add_node” that an error code would occasionally >> be provided by a call of a function like pseries_of_derive_parent(). >> This error indication was passed to an of_node_put() call according to >> an attempt for exception handling so far. > … > > I was notified also about the following adjustment. > > … > * linuxppc-dev: [resent,v2,1/2] powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() > - https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Flinuxppc-dev%2Fpatch%2Ff5ac19db-c7d5-9a94-aa37-9bb448fe665f%40web.de%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cab19d1c85de343f5474908dce3cd8c02%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638635719164841772%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=8b7APXbglDf13PvZ4nVh5Z92bEft2RBqU3LfKsUETOI%3D&reserved=0 > - for: Linux PPC development > was: New > now: Changes Requested > … > > It seems that I can not see so far why this status update happened > for any reasons. > Will further clarifications become helpful here? Sorry I forgot to send the email. It is the same kind of problem as the other series: Message IDs and/or In-Reply-To headers are messed up and b4 ends up applying an unrelated patch instead of applying the series as you can see below: $ b4 shazam f5ac19db-c7d5-9a94-aa37-9bb448fe665f@web.de Grabbing thread from lore.kernel.org/all/f5ac19db-c7d5-9a94-aa37-9bb448fe665f@web.de/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 128 messages in the thread WARNING: duplicate messages found at index 1 Subject 1: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 2 Subject 1: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node() Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch Assuming new revision: v3 ([PATCH] ipvs: Fix exception handling in two functions) Assuming new revision: v4 ([PATCH] selftests: cgroup: Fix exception handling in test_memcg_oom_group_score_events()) Assuming new revision: v5 ([Nouveau] [PATCH] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()) Assuming new revision: v6 ([PATCH] mm/mempolicy: Fix exception handling in shared_policy_replace()) Assuming new revision: v7 ([PATCH] firmware: ti_sci: Fix exception handling in ti_sci_probe()) Assuming new revision: v8 ([PATCH] remoteproc: imx_dsp_rproc: Improve exception handling in imx_dsp_rproc_mbox_alloc()) Assuming new revision: v9 ([PATCH] spi: atmel: Improve exception handling in atmel_spi_configure_dma()) Assuming new revision: v10 ([cocci] [PATCH] btrfs: Fix exception handling in relocating_repair_kthread()) Assuming new revision: v11 ([cocci] [PATCH] ufs: Fix exception handling in ufs_fill_super()) Assuming new revision: v12 ([cocci] [PATCH] perf cputopo: Improve exception handling in build_cpu_topology()) Assuming new revision: v13 ([cocci] [PATCH] perf pmu: Improve exception handling in pmu_lookup()) Assuming new revision: v14 ([cocci] [PATCH] selftests/bpf: Improve exception handling in rbtree_add_and_remove()) Assuming new revision: v15 ([cocci] [PATCH resent] btrfs: Fix exception handling in relocating_repair_kthread()) Assuming new revision: v16 ([cocci] [PATCH resent] ufs: Fix exception handling in ufs_fill_super()) Assuming new revision: v17 ([cocci] [PATCH resent] perf cputopo: Improve exception handling in build_cpu_topology()) WARNING: duplicate messages found at index 1 Subject 1: scsi: message: fusion: Return directly after input data validation failed in four functions Subject 2: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node() 2 is a reply... replacing existing: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node() WARNING: duplicate messages found at index 1 Subject 1: md/raid1: Fix exception handling in setup_conf() Subject 2: scsi: message: fusion: Return directly after input data validation failed in four functions 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 2 Subject 1: md/raid10: Fix exception handling in setup_conf() Subject 2: scsi: message: fusion: Return directly after input data validation failed in four functions 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: irqchip/gic-v4: Fix exception handling in its_alloc_vcpu_irqs() Subject 2: md/raid1: Fix exception handling in setup_conf() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 2 Subject 1: irqchip/gic-v4: Fix exception handling in its_alloc_vcpu_sgis() Subject 2: md/raid1: Fix exception handling in setup_conf() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_pciex_port_setup_hose() Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 2 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_probe_pcix_bridge() Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 3 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_probe_pci_bridge() Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 4 Subject 1: powerpc/4xx: Delete unnecessary variable initialisations in four functions Subject 2: powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: selinux: Improve exception handling in security_get_bools() Subject 2: irqchip/gic-v4: Fix exception handling in its_alloc_vcpu_irqs() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: selinux: Adjust implementation of security_get_bools() Subject 2: powerpc/4xx: Fix exception handling in ppc4xx_pciex_port_setup_hose() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: IB/uverbs: Improve exception handling in create_qp() Subject 2: selinux: Improve exception handling in security_get_bools() 2 is a reply... replacing existing: selinux: Improve exception handling in security_get_bools() WARNING: duplicate messages found at index 2 Subject 1: IB/uverbs: Delete a duplicate check in create_qp() Subject 2: irqchip/gic-v4: Fix exception handling in its_alloc_vcpu_irqs() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 1 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_pciex_port_setup_hose() Subject 2: IB/uverbs: Improve exception handling in create_qp() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 2 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_probe_pcix_bridge() Subject 2: IB/uverbs: Improve exception handling in create_qp() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 3 Subject 1: powerpc/4xx: Fix exception handling in ppc4xx_probe_pci_bridge() Subject 2: IB/uverbs: Improve exception handling in create_qp() 2 is not a reply... assume additional patch WARNING: duplicate messages found at index 4 Subject 1: powerpc/4xx: Delete unnecessary variable initialisations in four functions Subject 2: IB/uverbs: Improve exception handling in create_qp() 2 is not a reply... assume additional patch Looking for additional code-review trailers on lore.kernel.org Will use the latest revision: v17 You can pick other revisions using the -vN flag Checking attestation on all messages, may take a moment... --- ✗ [PATCH] perf cputopo: Improve exception handling in build_cpu_topology() --- ✗ BADSIG: DKIM/web.de ✓ Signed: DKIM/inria.fr (From: Markus.Elfring@web.de) --- Total patches: 1 --- Application de perf cputopo: Improve exception handling in build_cpu_topology()
>> I was notified also about the following adjustment. >> >> … >> * linuxppc-dev: [resent,v2,1/2] powerpc/pseries: Do not pass an error pointer to of_node_put() in pSeries_reconfig_add_node() >> - https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Flinuxppc-dev%2Fpatch%2Ff5ac19db-c7d5-9a94-aa37-9bb448fe665f%40web.de%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cab19d1c85de343f5474908dce3cd8c02%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638635719164841772%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=8b7APXbglDf13PvZ4nVh5Z92bEft2RBqU3LfKsUETOI%3D&reserved=0 >> - for: Linux PPC development >> was: New >> now: Changes Requested >> … >> >> It seems that I can not see so far why this status update happened >> for any reasons. >> Will further clarifications become helpful here? > > Sorry I forgot to send the email. It is the same kind of problem as the other series: Message IDs and/or In-Reply-To headers are messed up Three mailing list archive interfaces can present a mostly consistent view for the involved message threads, can't they? > and b4 ends up applying an unrelated patch instead of applying the series as you can see below: > > $ b4 shazam f5ac19db-c7d5-9a94-aa37-9bb448fe665f@web.de … This development tool is also still evolving. Are you looking for corresponding software extensions? https://b4.docs.kernel.org/en/latest/#getting-help How do you think about to start with the desired cover letter from the provided patch series for another integration attempt? Regards, Markus
diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c index 599bd2c78514..44f8ebc2ec0d 100644 --- a/arch/powerpc/platforms/pseries/reconfig.c +++ b/arch/powerpc/platforms/pseries/reconfig.c @@ -40,7 +40,7 @@ static int pSeries_reconfig_add_node(const char *path, struct property *proplist np->parent = pseries_of_derive_parent(path); if (IS_ERR(np->parent)) { err = PTR_ERR(np->parent); - goto out_err; + goto free_name; } err = of_attach_node(np); @@ -56,6 +56,7 @@ static int pSeries_reconfig_add_node(const char *path, struct property *proplist out_err: if (np) { of_node_put(np->parent); +free_name: kfree(np->full_name); kfree(np); }
Date: Tue, 21 Mar 2023 10:30:23 +0100 It can be determined in the implementation of the function “pSeries_reconfig_add_node” that an error code would occasionally be provided by a call of a function like pseries_of_derive_parent(). This error indication was passed to an of_node_put() call according to an attempt for exception handling so far. Thus fix the risk for undesirable software behaviour by using an additional label for this error case. Link: https://lists.ozlabs.org/pipermail/linuxppc-dev/2023-March/256025.html Link: https://lore.kernel.org/lkml/87pm9377qt.fsf@linux.ibm.com/ Reported-by: Nathan Lynch <nathanl@linux.ibm.com> Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- V2: This update step was added according to another change request. arch/powerpc/platforms/pseries/reconfig.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.40.0