| Message ID | 85d5d247ce753befd6aa63c473f7823de6520ccd.1564647619.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b214a8f2ea964b5ff2cc4a1e8bd8c74f64741f20 |
| Headers | show |
| Series | powerpc/xive: 2 small tweaks in 'xive_irq_bitmap_add()' | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f3365d1a959d5c6527efe3d38276acc9b58e3f3f) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
On 01/08/2019 10:32, Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. > GFP_KERNEL is also already used for another allocation just a few lines > below. This is correct. > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > arch/powerpc/sysdev/xive/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 8ef9cf4ebb1c..b4f5eb9e0f82 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -45,7 +45,7 @@ static int xive_irq_bitmap_add(int base, int count) > { > struct xive_irq_bitmap *xibm; > > - xibm = kzalloc(sizeof(*xibm), GFP_ATOMIC); > + xibm = kzalloc(sizeof(*xibm), GFP_KERNEL); > if (!xibm) > return -ENOMEM; > >
On Thu, 1 Aug 2019 10:32:31 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. > GFP_KERNEL is also already used for another allocation just a few lines > below. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- Good catch. Reviewed-by: Greg Kurz <groug@kaod.org> > arch/powerpc/sysdev/xive/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 8ef9cf4ebb1c..b4f5eb9e0f82 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -45,7 +45,7 @@ static int xive_irq_bitmap_add(int base, int count) > { > struct xive_irq_bitmap *xibm; > > - xibm = kzalloc(sizeof(*xibm), GFP_ATOMIC); > + xibm = kzalloc(sizeof(*xibm), GFP_KERNEL); > if (!xibm) > return -ENOMEM; >
On Thu, 2019-08-01 at 08:32:31 UTC, Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. > GFP_KERNEL is also already used for another allocation just a few lines > below. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Reviewed-by: Cédric Le Goater <clg@kaod.org> > Reviewed-by: Greg Kurz <groug@kaod.org> Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/2705ec100b46390851542fa97e920cc21ffaac4f cheers
diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c index 8ef9cf4ebb1c..b4f5eb9e0f82 100644 --- a/arch/powerpc/sysdev/xive/spapr.c +++ b/arch/powerpc/sysdev/xive/spapr.c @@ -45,7 +45,7 @@ static int xive_irq_bitmap_add(int base, int count) { struct xive_irq_bitmap *xibm; - xibm = kzalloc(sizeof(*xibm), GFP_ATOMIC); + xibm = kzalloc(sizeof(*xibm), GFP_KERNEL); if (!xibm) return -ENOMEM;
There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. GFP_KERNEL is also already used for another allocation just a few lines below. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- arch/powerpc/sysdev/xive/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)