diff mbox series

oob read in do_adb_query function

Message ID 74db5889.1519.181f54412b2.Coremail.sohu0106@126.com (mailing list archive)
State Superseded, archived
Headers show
Series oob read in do_adb_query function | expand

Commit Message

Ning Qiang July 13, 2022, 1:54 a.m. UTC 
In do_adb_query function of drivers/macintosh/adb.c, req->data is copy form userland. the  parameter "req->data[2]" is Missing check, the array size of adb_handler[] is 16, so "adb_handler[req->data[2]].original_address" and "adb_handler[req->data[2]].handler_id" will lead to oob read.
 


                req->reply[0] = adb_handler[req-
diff mbox series

Patch

diff --git a/adb.c b/adb.c_patch
index 73b3961..8a5604b 100644
--- a/adb.c
+++ b/adb.c_patch
@@ -647,7 +647,7 @@  do_adb_query(struct adb_request *req)


        switch(req->data[1]) {
        case ADB_QUERY_GETDEVINFO:
-               if (req->nbytes < 3)
+               if (req->nbytes < 3 || req->data[2] > 16)
                        break;
                mutex_lock(&adb_handler_mutex);