From patchwork Mon Aug 29 06:00:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 663490 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sN1KB0trPz9s1h for ; Mon, 29 Aug 2016 16:02:54 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3sN1K96MTBzDrh4 for ; Mon, 29 Aug 2016 16:02:53 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sN1Hr5gqczDrfT for ; Mon, 29 Aug 2016 16:01:44 +1000 (AEST) Received: from [192.168.1.3] ([77.182.223.245]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0M6mPA-1aslEO34vE-00wRsC; Mon, 29 Aug 2016 08:00:28 +0200 To: linuxppc-dev@lists.ozlabs.org, Andrea Gelmini , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras From: SF Markus Elfring Subject: [PATCH] powerpc: Use kmalloc_array() in grow() Message-ID: <68d9b20a-429c-e236-bd74-96d3f2a6a6b1@users.sourceforge.net> Date: Mon, 29 Aug 2016 08:00:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 X-Provags-ID: V03:K0:Yk9jRI4tkAsKpguYqC6yalpVtQpNI7u+mkOwdOcFg+h2LGYAxC9 skzt60qKvg80WyONimrb1AwUvkvjsiWYucwFU5DnnB+E4qlqAqnTxuA5WvPj1WMeMNC1rzI 5fkJqMrW6OGCID8fmp6qS37OiwW972y5YEU3p2BGUxZaYHMa6ZKlGr3++j1lGpqf3FkjdwH +0cIL4ppHJkdPJUjGSjRQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:Z6kLAFYgxGo=:BCFonhiXMBu5sFI/4gjPaF dOtPalUPE1uCw9kVDb0wreZB7z6cGEXUOZLR4Sp+70y4dI8bK1IahIoLyxXXy60n3twIhZEIT tUkMMpxdUr8wq+hh806EkYY80ATeo+pG4JiTmOagREZ0aZscr4RKPoUsu+MvA1frnFmQ+689M P0yC0ul3mhvc1lKsI8pEGwvAJyONZMKkyxoizSTD/lMKYb6oo5uIEH6s6b0jpzdQunv/M5k4B kCrtNf93Ax6/JzlF+74X8DSD8yHY21ckAVjw57KdHtdllEKcBMz2gEuebLxkSNTGiv76wHNRl y/iGWdmw4YxSeMQx8moRgdK11PFQ0f5BGkK6J/bhp75+B+fkKcK+4vRp8t2u82Xfe9EMXDXDa VRjN3UFlfIlGkJNd9Gd9xVFDiEtbPo6aEaYvojQwU6sx7wMMqpmYfiLfS4FrPrZWm99yPypuz Mpxf+91FJqZGNGiK9B7F+DLQVK8nhlKXK3clyEv00gqiLVjXRL4lJrTXINV45Q6ug4aTMVgPJ RQ92/jj4s9yPEKIgbIfX6yI3VDWZMBlutcSL6k98oPzv5YPrAGNS6GjnygyG0B2yLGwJ2wEuM 61hQPieNKmwtcAQjrG3mchUKJ53GyR60l6BCnoT1cz5qzLgC3EUU2C1P+5UVDUNK7VEv+fbXl v0AwoNV/LDDuNbruslH6AGMzif0j9W9qn4n16TgLDA8g7rAkBfwEIT4F+kpGd7FlyBtJcwsq6 mHRUMc+IedNMXKxOpkL6mHmqxKvA4w6vjUWRoL0L2yz59EmdSUtLXwiV5wf7lnFbq4/q8m8x7 ou+w/uu X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML , Paolo Bonzini Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Mon, 29 Aug 2016 07:50:33 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/lib/rheap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c index 94058c2..1630764 100644 --- a/arch/powerpc/lib/rheap.c +++ b/arch/powerpc/lib/rheap.c @@ -54,7 +54,7 @@ static int grow(rh_info_t * info, int max_blocks) new_blocks = max_blocks - info->max_blocks; - block = kmalloc(sizeof(rh_block_t) * max_blocks, GFP_ATOMIC); + block = kmalloc_array(max_blocks, sizeof(*block), GFP_ATOMIC); if (block == NULL) return -ENOMEM;