From patchwork Fri Nov 6 10:05:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 540910 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7F9E314029C for ; Fri, 6 Nov 2015 21:12:22 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 5E5051A0F93 for ; Fri, 6 Nov 2015 21:12:22 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 318 seconds by postgrey-1.35 at bilbo; Fri, 06 Nov 2015 21:11:27 AEDT Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8BF9D1A0CDB for ; Fri, 6 Nov 2015 21:11:27 +1100 (AEDT) Received: from [192.168.1.2] ([78.49.86.198]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MEmgA-1ZfjNt3BTW-00Fxxy; Fri, 06 Nov 2015 11:05:51 +0100 Subject: [PATCH] cxl: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org From: SF Markus Elfring Message-ID: <563C7B7A.2080403@users.sourceforge.net> Date: Fri, 6 Nov 2015 11:05:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:a0ZNZlN6+o0F2eCiral0tgqGbeW6zB96EW1KluSM4AzrlgoEF6f pUEcmpbbk3R4m2kpeP+jxsjeHDR6F+xLVkq0rV5zPuVU4fUx+hMGksox7f/TRul8RCq60fa 4jAE7v6tlj9x52l2vJQvTXMubDkplwxuFToY+znjErlJZ+neqEUpIEbF4HqsGpjKi5B7pWv wZ1/SjV+t8dZNBws2lmew== X-UI-Out-Filterresults: notjunk:1; V01:K0:huxeS+nCT2o=:wMFayAhvYp6/vxBbaU2IM+ v0ZhapQ7fh9Zsv6qDZnmufhOysVlHoER2+sHVSHPEgI5qRk4M7eLgIJ/TjPEc+ytfnIbZeXlG BTkOxSj+wzvg8yNGDNGwgveYBgcIkpQtB4JIY4LOMhGJ84xTii5acvufzKJiLqj3BMpqjFYD4 /cbZPopJjxbqPlSuzH10apTUITwghruitGqGMkCIp0MRVeHvd7NWzsbOgsEsjJQujarOOysjR Mx4aJpE1DeMxjY3HIodNhvN/BTBrqvTCm0EuvZai7L6nLQv39nAclzNmMK0imvJgz/v2IQMoT v8leyWAgnxuDjPv/bFxCaoM0XyIratUkXdBngOkVSHIcjuRRII2isBNHN7TjD30WEeTvf0+kQ PWd4TzZ9Oz+y5sYUHAqTltChbNHzO/AzFDs8lkI8rbLAXdMBEFUwYYFpL3+z9fTmPC7+WSIJr UI1F+I0b7phDIw2QIilJ72uP2cgr7oRkik+IWWtQlB8crT93yXbjreh8ORwKJbcO8aWsSaCG4 QVZvbCl5822r68tLyNjIMrIlFwUJ/ALNEDw7uJ3+rInxnay23f8epREztISuXuKZJsov283pj UQPQwwXMFyg4GkgJgYicTuol6qPgJ+1fu1J07+wfxyZ5gYHV0RO2webjzbAqjk9G2J2vBeqrj cSX+AimD9mo8RM2GC/sC3YxNMxkshHn1Oh0bInhubIIHgQKWqwqSAGdWYkZo++Fj9S4fl5d1t +3KWEUYX3IV0FkrV5D3aOTC6s6DEqcgZ8/7FIFeTdKrkDMYLfRBEos0+cyiW7mrJOD5I3qw7a VQcDdk6 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Fri, 6 Nov 2015 11:00:23 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Andrew Donnellan Acked-by: Ian Munsie --- drivers/misc/cxl/context.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c index 2faa127..52e39b6 100644 --- a/drivers/misc/cxl/context.c +++ b/drivers/misc/cxl/context.c @@ -275,9 +275,7 @@ static void reclaim_ctx(struct rcu_head *rcu) if (ctx->kernelapi) kfree(ctx->mapping); - if (ctx->irq_bitmap) - kfree(ctx->irq_bitmap); - + kfree(ctx->irq_bitmap); kfree(ctx); }