From patchwork Fri Dec 2 23:41:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timur Tabi X-Patchwork-Id: 128998 X-Patchwork-Delegate: galak@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id B603B100A82 for ; Sat, 3 Dec 2011 10:41:59 +1100 (EST) Received: by ozlabs.org (Postfix) id E156E1007D5; Sat, 3 Dec 2011 10:41:51 +1100 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from VA3EHSOBE009.bigfish.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 702FB1007D4 for ; Sat, 3 Dec 2011 10:41:51 +1100 (EST) Received: from mail108-va3-R.bigfish.com (10.7.14.239) by VA3EHSOBE009.bigfish.com (10.7.40.29) with Microsoft SMTP Server id 14.1.225.22; Fri, 2 Dec 2011 23:41:47 +0000 Received: from mail108-va3 (localhost [127.0.0.1]) by mail108-va3-R.bigfish.com (Postfix) with ESMTP id BE7875C0401 for ; Fri, 2 Dec 2011 23:41:46 +0000 (UTC) X-SpamScore: -3 X-BigFish: VS-3(zz98dKzz1202hzzz2dh2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail108-va3 (localhost.localdomain [127.0.0.1]) by mail108-va3 (MessageSwitch) id 1322869306653435_11247; Fri, 2 Dec 2011 23:41:46 +0000 (UTC) Received: from VA3EHSMHS033.bigfish.com (unknown [10.7.14.243]) by mail108-va3.bigfish.com (Postfix) with ESMTP id 99B0580044 for ; Fri, 2 Dec 2011 23:41:46 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS033.bigfish.com (10.7.99.43) with Microsoft SMTP Server (TLS) id 14.1.225.22; Fri, 2 Dec 2011 23:41:44 +0000 Received: from az33smr02.freescale.net (10.64.34.200) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server id 14.1.339.2; Fri, 2 Dec 2011 17:41:43 -0600 Received: from [10.82.123.3] (efes.am.freescale.net [10.82.123.3]) by az33smr02.freescale.net (8.13.1/8.13.0) with ESMTP id pB2NfgIK015670; Fri, 2 Dec 2011 17:41:42 -0600 (CST) Message-ID: <4ED96236.9030505@freescale.com> Date: Fri, 2 Dec 2011 17:41:42 -0600 From: Timur Tabi Organization: Freescale User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111107 Firefox/8.0 SeaMonkey/2.5 MIME-Version: 1.0 To: Scott Wood Subject: Re: [PATCH 2/2] powerpc/85xx: add a 32-bit P1022DS device tree References: <1322863714-6818-1-git-send-email-timur@freescale.com> <1322863714-6818-2-git-send-email-timur@freescale.com> <4ED94EF5.2090406@freescale.com> <4ED95006.9010301@freescale.com> <4ED95287.1010606@freescale.com> In-Reply-To: <4ED95287.1010606@freescale.com> X-OriginatorOrg: freescale.com Cc: linuxppc-dev@ozlabs.org, kumar.gala@freescale.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Scott Wood wrote: > Nothing that happens in Linux excuses handing Linux a device tree that > is wrong. That you need special handling in Linux indicates that this > is not a simple-bus. How about this: diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts index 16239b1..2a62edd 100644 --- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi +++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi @@ -35,7 +35,11 @@ &lbc { #address-cells = <2>; #size-cells = <1>; - compatible = "fsl,p1022-elbc", "fsl,elbc", "simple-bus"; + /* + * The localbus on the P1022 is not a simple-bus because of the eLBC + * pin muxing when the DIU is enabled. + */ + compatible = "fsl,p1022-elbc", "fsl,elbc"; interrupts = <19 2 0 0>; };