From patchwork Thu May 4 15:06:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Schindele X-Patchwork-Id: 758604 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wJdgc48XPz9s2Q for ; Fri, 5 May 2017 01:07:56 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wJdgc2scBzDqFx for ; Fri, 5 May 2017 01:07:56 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from dmz-mail.nentec.de (gate.nentec.de [213.218.23.37]) by lists.ozlabs.org (Postfix) with SMTP id 3wJdfS0hGmzDqCL for ; Fri, 5 May 2017 01:06:54 +1000 (AEST) Received: from (unknown [153.92.64.119]) by dmz-mail.nentec.de with smtp id 3280_a3c1_41c0a2d4_30db_11e7_9d6c_000c29a8555f; Thu, 04 May 2017 17:06:32 +0200 Received: from localhost (localhost [127.0.0.1]) by zimbra.nentec.de (Postfix) with ESMTP id 56D5717E08AA; Thu, 4 May 2017 16:57:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at nentec.de Received: from zimbra.nentec.de ([127.0.0.1]) by localhost (zimbra.nentec.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XqCBpt7g140S; Thu, 4 May 2017 16:57:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.nentec.de (Postfix) with ESMTP id 3551D17E13CC; Thu, 4 May 2017 16:57:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at nentec.de Received: from zimbra.nentec.de ([127.0.0.1]) by localhost (zimbra.nentec.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RlJMYu83Xjz8; Thu, 4 May 2017 16:57:04 +0200 (CEST) Received: from sherry.localnet (sherry.nentec.de [153.92.64.8]) by zimbra.nentec.de (Postfix) with ESMTPS id 1845817E08AA; Thu, 4 May 2017 16:57:04 +0200 (CEST) From: Juergen Schindele To: Scott Wood Subject: Re: Freescale mpc8315 IRQ0 setup Date: Thu, 04 May 2017 17:06:37 +0200 Message-ID: <41499955.CTp69um5pn@sherry> Organization: PSI NenTec User-Agent: KMail/4.14.10 (Linux/3.16.7-42-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: <1493782174.25397.31.camel@buserror.net> References: <2666241.ms6yMRjznt@sherry> <1715435.xdU3769208@sherry> <1493782174.25397.31.camel@buserror.net> MIME-Version: 1.0 X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: -5000 X-NAI-Spam-Version: 2.3.0.9418 : core <6016> : inlines <5845> : streams <1744035> : uri <2421154> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: schindele@nentec.de Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Am Dienstag, 2. Mai 2017, 22:29:34 schrieb Scott Wood: > On Tue, 2017-05-02 at 14:43 +0200, Juergen Schindele wrote: > > Dear Scott, > > sorry for the delay but i am not very familiar with the formating. > > I passed the patch trough checkpatch.pl and there was no more error. > > pease find patch in attached file. > > Thanks > > Documentation/process/submitting-patches.rst explains the way to format and > submit kernel patches. > > Also, why the unrelated change to a print statement in ipic_set_irq_type()? > > -Scott The second diff is not completely unrelated because when i was investigating the problem i saw only a message "edge sense not supported" but you dont know on which interrupt he is complaining about. So i added this to find out who the suspect is. Corrected patch Signed-off-by: Jurgen Schindele Signed-off-by: Jurgen Schindele [PATCH] configure "EDGE" capabilities for IRQ0 (like IRQ1-7) Signed-off-by: Jurgen Schindele --- a/arch/powerpc/sysdev/ipic.c 2016-12-11 20:17:54.000000000 +0100 +++ b/arch/powerpc/sysdev/ipic.c 2017-04-04 15:28:11.201308780 +0200 @@ -315,6 +315,7 @@ static struct ipic_info ipic_info[] = { .prio_mask = 7, }, [48] = { + .ack = IPIC_SEPNR, .mask = IPIC_SEMSR, .prio = IPIC_SMPRR_A, .force = IPIC_SEFCR, @@ -617,7 +618,7 @@ static int ipic_set_irq_type(struct irq_ /* ipic supports only edge mode on external interrupts */ if ((flow_type & IRQ_TYPE_EDGE_FALLING) && !ipic_info[src].ack) { printk(KERN_ERR "ipic: edge sense not supported on internal " - "interrupts\n"); + "interrupts %d\n", src); return -EINVAL; }