From patchwork Mon Jan 31 07:15:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Leroy X-Patchwork-Id: 1586549 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JnK8v6QKSz9sFr for ; Mon, 31 Jan 2022 18:15:43 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JnK8v2dn4z30RR for ; Mon, 31 Jan 2022 18:15:43 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=2a01:111:f400:7e19::617; helo=fra01-mr2-obe.outbound.protection.outlook.com; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01on0617.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e19::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JnK8j3r9zz2xsb for ; Mon, 31 Jan 2022 18:15:32 +1100 (AEDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BUO1tXczrSNeJECLJHmtcWDF8wQ/nFHSMAozGvwpsGj7zdbGO5gJDrzmtsAL1EPw9wmXnXM203w2q2I96Z+aOGwzFr7Ll3mRoukB0jpBEOGzrlp5Fam5v5owPrAvXJsRj3sNo5ZCuAQVeYT67/1ms/7+/aIKOCEZIUcvP7b7Qv1DIwEWujQYeja3/HcDWCFb7uLKv4tK5Mq1CXHNgCk/qsgJ6amG5kBnSgVKxZ8GTzSKq9109J3lhHBebC0B8fh6WHfydZIIDSaIAXBZhAJSpOLvvPmPcBzhACTOlofrnL7Kdt7N31MJejti0n1lWO1xOnGVEigOL3R53juhGQoA5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ncunWZo1zlaP7DI8kZp9PROBhpSZplPQs/0cNakHQ5Y=; b=IxUiwsDyxI+3EQXqtkrw3UvWPfUL9wAmZsAZcyeoasbt9nOFxWh95zBdR4OWbJeIlARGsy4PwbwmjPIzmUSYJkm9s+ikrjBKvkp+mbYs1H0QK1+ddTRtXeBzPUSYDgRqj8mNZjV2DrO8GxE8kcXrd+NNFWtZGjZmnhJSuwI7MfGxB/80BuMTX8/HXp0aSyauVN/DjnPtLnPDmazURVXkz1r4+14M6f5TPxlhltH2NX53H4O8RtCiDPfOJpkJnZJOy6GgZvGDnUIm40qJwSDNDkyuZnAiuMQWpNq+6ikc8wEXH2sIHu6DKU+K9oq19+OVJeHGID5qBxwWjGTmqvi/dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:31::15) by MRXP264MB0405.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:17::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Mon, 31 Jan 2022 07:15:12 +0000 Received: from MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM ([fe80::c9a2:1db0:5469:54e1]) by MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM ([fe80::c9a2:1db0:5469:54e1%6]) with mapi id 15.20.4930.020; Mon, 31 Jan 2022 07:15:12 +0000 From: Christophe Leroy To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [PATCH] powerpc/603: Remove outdated comment Thread-Topic: [PATCH] powerpc/603: Remove outdated comment Thread-Index: AQHYFnJJstMpforeEU2l/M5eRfg0Ig== Date: Mon, 31 Jan 2022 07:15:12 +0000 Message-ID: <38b1ffefd2146fa56bf8aa605d476ad9736bbb37.1643613296.git.christophe.leroy@csgroup.eu> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=csgroup.eu; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0444bd4-2b54-4c59-3689-08d9e4896c3e x-ms-traffictypediagnostic: MRXP264MB0405:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YHBZHgl0J1vAArq8UiK6TZfRRlXGfkC9WVHXmiSB1EeomcStTHRS//VZUNOhRxOg4/KUWDc+rSYVzYt/x9V7YOph9/M31TJdf6kPpgWQR+VN/YAC3xP/KMzY4lRg3zk8BxeD3FQdUmsnmerQ2etLpPgf4goVM1O26btnLLnNcd0LnieUKPPl3mI+82sUKKowSuuXaXwFAQQReBDXaFeL4Q31DbtYRofUOlKKUn0RwyCzjVECn0QEGMrm1Ya/2hS8aLiey8hXGsDvSIRuP6bfmkDiWOm0Apb1hjfLYdou8Nb5qSISK3Ws6oAIxlqc/og6y2UZ9irBty02HYB1KT12MFd4G3Gv0PjSsa9nPbu2y8SsvDp9Yv9b8gslRbxmU0lT8urHrOVTJMS6BrLrdMpKKlCfcoS3UfEZcLD5PK7il/W85QgbsSVuE9msm37E3ZdBG5gpYY6K/+i4DM9W6hFxYOQqoVqfKGKEiiZHeUnPwATBre4hbZ3U9BaL373zttKZNQhyDnAtD8ZBiSlqQVlP2s1thbmWsbx5EZLzf78GUugq+M1lbPEFpetTjm5IEaLaAeTx0Cpa/WlCT8pYWA0+D60oZCzdlSIQsnJEyle1Sf0C+K19VJq6fBkzo2SiukTOkXOyeiBpHPyO6GMMJoMGj3ux3UhSfzGDJovO4EVODjKML3z5FRwPj/+dEuOmY0VoxfAc3fJQn2BhusOzBO+iOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(91956017)(76116006)(83380400001)(8676002)(44832011)(64756008)(66446008)(66476007)(4326008)(71200400001)(66556008)(186003)(5660300002)(26005)(2616005)(2906002)(66946007)(8936002)(6506007)(6512007)(6486002)(110136005)(54906003)(122000001)(508600001)(38100700002)(86362001)(38070700005)(316002)(36756003)(20210929001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?pxJTGHiXJ9FCxqKJ409JoWc?= =?iso-8859-1?q?bc/E9FheKx/u0A4v3tlm+0V3d/xQb7odMplFlReRKC0j8nYMNHGepgSVz41m?= =?iso-8859-1?q?ob4kkBeK6Ij8/53L8+7MYH6n1a66Z/z7AxWVakEcBQray6KMQ706XdTYVbg3?= =?iso-8859-1?q?1TJ1cDEHXqQ0uxG/zWX59Phx6qxiZRYdMOio7mB+xhJYVFCcai8dXM/cNtgV?= =?iso-8859-1?q?r1UxccufgUIy73+iyglDSs5vmFFtbMD6+WjiZljz37w9QZkRCDMo+gz6k6Uc?= =?iso-8859-1?q?zuc/CE7F3izIt8b8lPzN8waIr+28LvjjzHhuudl/xOshT2AqvyJUxTzUSsco?= =?iso-8859-1?q?YYP9HdVbCFRWidEr47ZgexIZ3KyMZXyf1OLHzxHY2/0GoB1EvLx+94H1EPED?= =?iso-8859-1?q?TTV9Mf66ApLRlmBuphpaEFtyaVu+7MYqAzTGiCK119f1svgrVw5aZ3MFSMao?= =?iso-8859-1?q?N6TZIE0hxpUt7L85wKd+jcweLmZw+tyG2GchufUm0eTyT26x74BjI1tDzXgb?= =?iso-8859-1?q?OQ5nSdRmIKEs9sqt1SU0f6tDeFaEzROuYl//PP/4izqjPVzkbSXN1xdioM2Y?= =?iso-8859-1?q?mMFinEYtpshBPyoH3DD118hVmDuPm5puYyb51IdGyTAHq9SDfV1JuGANC+lq?= =?iso-8859-1?q?KmKfMy7uJH8Z/kj37wRrVsrPpzarehyGQMpZzXSlAV0QFMrP+7qwsk/3e2nC?= =?iso-8859-1?q?XNrCkGmm+3kUL0nnhry7I5Epav+7mimpSlqyqMEy6a51r+W50pBmkkjm24qs?= =?iso-8859-1?q?m2OEURmULYM2KlpNA/dR7UjHsPMOgqtCrN/Wif9AacG2TzWiLsvdOpbFTndc?= =?iso-8859-1?q?zV4B8z6iVcbci27irvDnwuQG5jZS+Xkq40Vtsuu2OO7JopPcX9IdGGR02BzN?= =?iso-8859-1?q?rvJMqLfbuPITmUc4tWAUI03542j/Wd+9JjVaDOIg4MfOaVteBvhbX2dHLVhm?= =?iso-8859-1?q?zFxY03swQM/YlaACi6hA5LWXb9SAoqCk9yClo0JS/Ndh4CJB3j+cgblhZRml?= =?iso-8859-1?q?JE838QE47r0d4A5hPAgHnBRTqGoMAmZbEW5ZhZufoRB7z+kJZ52miVBfb8uE?= =?iso-8859-1?q?kU9Pan+w2tpd9Jx7IbL1Rgeqgefw0OQcTzX78HVqwDfznMM+KRk4WoWNL/ox?= =?iso-8859-1?q?j2xduXr4tsQI9xjpVemhy9dUkTTRaO2MdGOBPGY+uF+gc+nC8hLT0gOPdLbj?= =?iso-8859-1?q?KxsVbIhvkkvL8uZzwrmg58s2Y0b9XvnMJrkpAtaCq7HpeZ35svOmilo8V5ZK?= =?iso-8859-1?q?D+ipvqOuc3Eidq54Ab3+xvYkmhaIuJC9YsG7v2bqpu/1EJ60RySPAqRHO2WV?= =?iso-8859-1?q?CTbJh6B+dgLkzcwW5CUKOVFMaLzlhOS8cSIfTD8zGsN52TyChdBAh2Z0+Rfn?= =?iso-8859-1?q?CAY8ZZ9BeB1D28AGt+/lmhNRpZ/5UubrimF0L/PuPzm6AS917NTo8oKUg/Xl?= =?iso-8859-1?q?/kGMEVnzRrpCA7fZ1/qMy/VrBs9QN5BCbCyBaLCyOm7SoZzG3pVliXBRxbbr?= =?iso-8859-1?q?cUT4RJt23k9fJkrnYj0ibw2ZoY3SZjbSMtRy2Kc+u4FPrZG3rNxtJmNdBGmN?= =?iso-8859-1?q?LgO0wpOgM1oQXeMP8DY93Q0qopNaU/7wh5/spVLm4Ra+S4nlPKY8mUwIq1xr?= =?iso-8859-1?q?WoXWnU+Ni2QN61SUttwXayLQ6XVZFHt6/gTdN/sZnoKxd1jbrRutPSbPYtjX?= =?iso-8859-1?q?6nBjYzj3TQ1zEN7QCZ5cx1GpwsanFpZueqie5lhfEupLqwI9DjY2Sl5tbJg6?= =?iso-8859-1?q?g6vA=3D?= MIME-Version: 1.0 X-OriginatorOrg: csgroup.eu X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a0444bd4-2b54-4c59-3689-08d9e4896c3e X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 07:15:12.6679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y4c/+JITCxdFgvrUtjJViTfYCh024MUVG26M31RUiooV7wNAP67LWUsrIkhlJSn+UCB4A0A4dozNWuT4k5S5LNdYxMxc8k1R2+aWmHSF988= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRXP264MB0405 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Since commit 84de6ab0e904 ("powerpc/603: don't handle PAGE_ACCESSED in TLB miss handlers.") page table is not updated anymore by TLB miss handlers. Remove the comment. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_book3s_32.S | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/powerpc/kernel/head_book3s_32.S b/arch/powerpc/kernel/head_book3s_32.S index 937c79b8ad0f..6c739beb938c 100644 --- a/arch/powerpc/kernel/head_book3s_32.S +++ b/arch/powerpc/kernel/head_book3s_32.S @@ -501,10 +501,6 @@ DataLoadTLBMiss: lwz r0,0(r2) /* get linux-style pte */ andc. r1,r1,r0 /* check access & ~permission */ bne- DataAddressInvalid /* return if access not permitted */ - /* - * NOTE! We are assuming this is not an SMP system, otherwise - * we would need to update the pte atomically with lwarx/stwcx. - */ /* Convert linux-style PTE to low word of PPC-style PTE */ rlwinm r1,r0,32-9,30,30 /* _PAGE_RW -> PP msb */ rlwimi r0,r0,32-1,30,30 /* _PAGE_USER -> PP msb */ @@ -585,10 +581,6 @@ DataStoreTLBMiss: lwz r0,0(r2) /* get linux-style pte */ andc. r1,r1,r0 /* check access & ~permission */ bne- DataAddressInvalid /* return if access not permitted */ - /* - * NOTE! We are assuming this is not an SMP system, otherwise - * we would need to update the pte atomically with lwarx/stwcx. - */ /* Convert linux-style PTE to low word of PPC-style PTE */ rlwimi r0,r0,32-2,31,31 /* _PAGE_USER -> PP lsb */ li r1,0xe06 /* clear out reserved bits & PP msb */