From patchwork Wed Jul 20 13:20:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 650667 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rvd4p2rstz9t0F for ; Wed, 20 Jul 2016 23:27:38 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3rvd4p23mqzDqYv for ; Wed, 20 Jul 2016 23:27:38 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 320 seconds by postgrey-1.35 at bilbo; Wed, 20 Jul 2016 23:26:40 AEST Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rvd3h55GhzDqTj for ; Wed, 20 Jul 2016 23:26:40 +1000 (AEST) Received: from [192.168.1.2] ([77.181.180.179]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0Lecda-1b05iM3SQQ-00qSyg; Wed, 20 Jul 2016 15:21:00 +0200 Subject: [PATCH] cxl: Delete an unnecessary check before the function call "of_node_put" To: linuxppc-dev@lists.ozlabs.org, Christophe Lombard , Ian Munsie References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> From: SF Markus Elfring Message-ID: <33fb6b04-9986-35ee-f4e2-0ebeb79c5e23@users.sourceforge.net> Date: Wed, 20 Jul 2016 15:20:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:+El2nwirCK3O+Ne04Ww8bar11JWcjfoBY/Syzdrx70EEyCVkxZq Z1UBspIX2yxPmE+pDNA6L0tNOxeK1phwCQ+/M8fvdWZJ7LB2+1DLcHlOcDeNFnTi5/Vy3Jx VVdHJIZgKMlkWENKbFmHBjZJ1b6PaPDFVyJGUVsAs8rq/AhHf2KMXlp6Z/Q/64mER95TEiR TWAhNBS85WoViz5wqET4A== X-UI-Out-Filterresults: notjunk:1; V01:K0:OAdQAb0tElo=:nP+Y1VPv5DHA1q2dKHADkH KlAzoQ+BwjwqIIoFlbECq68Qvw631oK89vAnTZmjCW2JfhieikhI9neXo4iTWVbiHpAgwZBf+ 82888aGosGW3/Ah2qegVzLfXa/IXMkFKbkiLszj2dvnrsUw+gzW45aeKMrUlMaDPOL0gsJa7a nYfdzas54VZTV62OpDi6kBni0yKMvQIsjaBpWwI7+O5yuwOkErJJRsf6DT/4XLLBYnYXhQ8LW AItGo60A5O9fU1NNpX5jie9lhu4irMMMGeWd+bOuTpd4DnJm7mSf2BwCfdEwKgmgNXnS34Dpr vsokeFNhiCV1tPU1U/c2vL+CbsSJQ6nM7nT1ZbKA5mz0uRy3q1adGkB7Dzo/L91Zy7623993K eGdc19JYGYxlwvyt4yso1Tot7mI8S2KID0XrwVRNw9Ox3BFcVXCmKju7RF8TGG2nqUX0mv11C OQnoSDwifO3cmRHsgTCqjmOo817ktvlV7U9Ut0W7lT42AyR5XKCjDT99lC0nvyWckH1G14+Qc AiNOEZGYTPdSNrOk5sareNjSo+/ybIujHPPN1LZ5L0rBTmLTtLAMm9RbzdBMryGpJNnVncRWU D1LaHHOR9uF0K0HYMYjWSmVCUU0ca3IyeosYrooKQg6aEiaxrtCp75BhO+003o9gSWhELbchW /gGogOGIv1c48m6QdnjrYFvgaEltQf5mbqkbigCxJgAhbwAvZH96U2voRACoFxQELbBAq4KBY ocXpLm8dBxdIP/ZZnnXlo8O5W/VDbfTGxpDlrVnOSh/vfI2Hl3j8OnwXz6nq+3SqkdHM9rO5Q Zmef7L6 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 20 Jul 2016 15:10:32 +0200 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/cxl/of.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c index edc4583..333256a 100644 --- a/drivers/misc/cxl/of.c +++ b/drivers/misc/cxl/of.c @@ -490,8 +490,7 @@ int cxl_of_probe(struct platform_device *pdev) adapter->slices = 0; } - if (afu_np) - of_node_put(afu_np); + of_node_put(afu_np); return 0; }