From patchwork Sun Aug 28 17:12:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 663396 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sMhQm6WjHz9sBM for ; Mon, 29 Aug 2016 03:21:36 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3sMhQm5hwFzDrqC for ; Mon, 29 Aug 2016 03:21:36 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 342 seconds by postgrey-1.35 at bilbo; Mon, 29 Aug 2016 03:19:07 AEST Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3sMhMv6DnwzDrff for ; Mon, 29 Aug 2016 03:19:07 +1000 (AEST) Received: from [192.168.1.3] ([77.181.152.74]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0Meji8-1bT6MG3NCi-00OCUn; Sun, 28 Aug 2016 19:13:01 +0200 Subject: [PATCH 1/6] KVM: PPC: e500: Use kmalloc_array() in kvm_vcpu_ioctl_config_tlb() To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Alexander Graf , Benjamin Herrenschmidt , Michael Ellerman , Paolo Bonzini , Paul Mackerras , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <566ABCD9.1060404@users.sourceforge.net> From: SF Markus Elfring Message-ID: <317e0112-55cc-cc91-100f-bc5e301dbe76@users.sourceforge.net> Date: Sun, 28 Aug 2016 19:12:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:nnRYpQNy/zUgfXokf10zmHplNTFlC2daV6+9mUFmArQwYHhkAR9 O2zMTrnWOAO9+nsuQhFVBshF9HGLLdjNwelst6INnLXRJnVYKTjIxGXEgJfwV2cuL4z7Y+6 7n0yF4A2TeH8kmZQtyoDY6U17UUxpLIBV5v+En3/CwaOX1T0iXDFCYg8J02ZeAnGIZrI9Fv 1sKhSi1EH0Xqb0bMT9NJQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:lfkqa7r1SWU=:iTvQLwB7oCBW7xRxcvrt/S H/eCD4DjJi1MvEH28x2TYbqQ5JMLEUovLOfCXuSRzF0FL7JW6nsdkkX0BGhvGxJ6BzM3Zx95Z UIg10WtRG5tQmv0S6HfpmdEHmVUCkKVpWD6LjqC/ZSuGKQylAXuZU8cNKAWO9zLEdiTZUOBC6 N3zkEMN1VvrJssnabJoCH4xPDYRrqWiqTvfS/3YyX3phi8v5BPdO36qe+Qjeu1A2kaEHTApC+ kp04CxtKfKQmJNXZAE+PcO/xFyus5clH10Jd3B8+BYh5SpeCSz3ZqSABdebK+c5T04rvaC6z1 YVhjDvyFfAWoqbDb64vuCBZSgAmYxmlC0VS6VnRLi3S6D7XZjVHjIrEedEWiuWCJLffrunpHZ 7wcWY6QCtzlCEDdyUrnhTWWjTVpNbI5ts6XKC+96UWo6CM5G7FP5Ellvs5B2C6G56Vm0gruSe QmbFvoN48je8vGti0nMvx5NXx7ZWMStK39HbdcF4gzHGfG+xN86FZoX1E9h4ebbHKoVRXj5dl RC9cfvRqmf+Ju3CgQ52Nm20v6dxxocmy0AAdukcjF/uO2dc9BzSqdJl084y03VmcT3CObAY2B Pw3o1jJVuBdovyaXt3uakfZl+SpQCPRNPynH3+IcFWItvxooRouJndjvnTMdr2jHbq+dH9wRf lZmZ9UNa/+xiZbxG9FBEBS2G6Fwg2vpe8/YLvajz+C/SKwYFgPh9JE93K7h+i6VqbpvQwMMZq k7t9qW4VtGQ3XuDbiM8eG9QoGs8+WnpHKmHqd5SiPrpyYNITyIiV587peFOh0oDa4unRcbgA6 WJnLMn4 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Sun, 28 Aug 2016 16:30:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/kvm/e500_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c index 29911a0..26f3737 100644 --- a/arch/powerpc/kvm/e500_mmu.c +++ b/arch/powerpc/kvm/e500_mmu.c @@ -779,7 +779,7 @@ int kvm_vcpu_ioctl_config_tlb(struct kvm_vcpu *vcpu, num_pages = DIV_ROUND_UP(cfg->array + array_len - 1, PAGE_SIZE) - cfg->array / PAGE_SIZE; - pages = kmalloc(sizeof(struct page *) * num_pages, GFP_KERNEL); + pages = kmalloc_array(num_pages, sizeof(*pages), GFP_KERNEL); if (!pages) return -ENOMEM;