From patchwork Wed Dec 13 17:34:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 848069 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yxkYL6jDVz9s83 for ; Thu, 14 Dec 2017 04:42:46 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3yxkYL2nd0zDqhn for ; Thu, 14 Dec 2017 04:42:46 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.15.14; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yxkNC3hlpzDrp4 for ; Thu, 14 Dec 2017 04:34:51 +1100 (AEDT) Received: from [192.168.1.3] ([77.181.208.154]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M6DjG-1fEQ012e1C-00yBR3; Wed, 13 Dec 2017 18:34:43 +0100 Subject: [PATCH 2/3] soc/fsl/qe: Improve a size determination in two functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Li Yang , Qiang Zhao References: <07738369-a787-98b4-41a5-71b7d630c356@users.sourceforge.net> Message-ID: <24d6e67d-6bbf-5d2b-5003-79b50a84f268@users.sourceforge.net> Date: Wed, 13 Dec 2017 18:34:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <07738369-a787-98b4-41a5-71b7d630c356@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Bknh5tprI4K9hLjMFRoXCuy7V2vdm9dtQswKtHzoM3kn7Qx0Yrg hrGfJapLkckImP3eRh1i5PlQHnsxJO6WaUCX2/ntfwV/9Ury32yUiJJEn1fDDOJZLKqslUr CNRBF0VdObcc/KYSoPmNSE+2ArttExhz0oRHwIsZUnMW02w2yYKy0U07N1m/GcCyIOjXLR0 W96VT7W2M9WfrYt2pj/GA== X-UI-Out-Filterresults: notjunk:1; V01:K0:0sY9zY3Oq14=:X+xAI1aC39p1Q0r5TF6xi3 EK3wJpWz6M3XxAha2k4/YERqnOlnbTzFmwm4Zbw4ngE4A3GjUXWFr0EJ7kutYy3Ghdf3yXh0F SV+KNwhWzcFwygeh7GHXse0rctC2OsnsHS9lWCOjw3spAzJVXsRDP+LkWfpKNXM5LH44b8N06 uM1/fM2yDVCKWWiPeo8dhoNaDDnqQWesRiG0f3O+cBUkqUEtT7BFxjr+1bof4eHqrA0SGMZeq QNOi5qCCSl0Sp8K3yfqd9S/46hihaVybvApz5yQEZsaRDndNDBYvoJllmC9uOjRls8RiRt/wq l0DMwtj4B+TuCiHnnNtnIvVRFdde2Wkh0jCZUTgZb2olTXYOEHw7WO8GSZ6CzzJeqsPzjStF0 aremNFeWUjxo0jjJZ8SNYluSJMyjNQelQbnH+aIyDf6pzNjec5GMbMKMdileRv0tvecfShc0m d+jQtatPqaJk4Sm72hrtselbqJRTOjvqvYRpb2vTR12Xcs8qSfFKq52E8J4wcte+w9FWeGQuq 1MoH9P1xi2Q6Z6QVuUfCthAeS9T+vxynU7tq4g9QWb/wgTl4IrosVQ8x28a/U1GkzbWj9XDpA A7Q8UzuBKZy9t1jgm3sUhr/TFiquV8ldLHLUo0DEU4ZT/fxE89tf6LMp8Wat6No2Hqv9hC5ce tUd0U3/yJel3UVfKtQDbnXFPuGPS/CoPX1ghwEpVDL7ogNBg+Kp8jiDNr+muUSJyvlbwwamg6 jMiE46RsnKPPUOJwASF3bGDIzfnnKD1JZWWNZ5xOLSpzqiuW7LfVopohTOC4nB1Oxf/yZGwiG 2yWN0EJhFTkD9wa3ZH9p8ziYo2BHjJc0N0b8Mo1fye7NAR80S0= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Wed, 13 Dec 2017 17:51:21 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/soc/fsl/qe/ucc_fast.c | 2 +- drivers/soc/fsl/qe/ucc_slow.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qe/ucc_fast.c b/drivers/soc/fsl/qe/ucc_fast.c index 59b68bf4aebb..2092bfdcf1bc 100644 --- a/drivers/soc/fsl/qe/ucc_fast.c +++ b/drivers/soc/fsl/qe/ucc_fast.c @@ -194,7 +194,7 @@ int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** ucc return -EINVAL; } - uccf = kzalloc(sizeof(struct ucc_fast_private), GFP_KERNEL); + uccf = kzalloc(sizeof(*uccf), GFP_KERNEL); if (!uccf) return -ENOMEM; diff --git a/drivers/soc/fsl/qe/ucc_slow.c b/drivers/soc/fsl/qe/ucc_slow.c index fc91412e2300..c21a42c11080 100644 --- a/drivers/soc/fsl/qe/ucc_slow.c +++ b/drivers/soc/fsl/qe/ucc_slow.c @@ -152,7 +152,7 @@ int ucc_slow_init(struct ucc_slow_info * us_info, struct ucc_slow_private ** ucc return -EINVAL; } - uccs = kzalloc(sizeof(struct ucc_slow_private), GFP_KERNEL); + uccs = kzalloc(sizeof(*uccs), GFP_KERNEL); if (!uccs) return -ENOMEM;