diff mbox series

powerpc: increase MIN RMA size for CAS negotiation

Message ID 20241205101045.27069-1-avnish@linux.ibm.com (mailing list archive)
State Superseded
Headers show
Series powerpc: increase MIN RMA size for CAS negotiation | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_ppctests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_selftests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 5 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 21 jobs.

Commit Message

Avnish Chouhan Dec. 5, 2024, 10:10 a.m. UTC
Change RMA size from 512 MB to 768 MB which will result 
in more RMA at boot time for PowerPC. When PowerPC LPAR use/uses vTPM,
Secure Boot or FADump, the 512 MB RMA memory is not sufficient for 
booting. With this 512 MB RMA, GRUB2 run out of memory and unable to 
load the necessary. Sometimes even usage of CDROM which requires more
memory for installation along with the options mentioned above troubles
the boot memory and result in boot failures. Increasing the RMA size 
will resolves multiple out of memory issues observed in PowerPC. 


Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
---
 arch/powerpc/kernel/prom_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Madhavan Srinivasan Dec. 5, 2024, 12:05 p.m. UTC | #1
On 12/5/24 3:40 PM, Avnish Chouhan wrote:
> Change RMA size from 512 MB to 768 MB which will result 
> in more RMA at boot time for PowerPC. When PowerPC LPAR use/uses vTPM,
> Secure Boot or FADump, the 512 MB RMA memory is not sufficient for 
> booting. With this 512 MB RMA, GRUB2 run out of memory and unable to 
> load the necessary. Sometimes even usage of CDROM which requires more
> memory for installation along with the options mentioned above troubles
> the boot memory and result in boot failures. Increasing the RMA size 
> will resolves multiple out of memory issues observed in PowerPC. 

Can you add more on the failure details here list a stack trace or dump,
also is there a selftest to verify the fix in qemu or lpar?

> 
> 
> Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
> ---
>  arch/powerpc/kernel/prom_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index fbb68fc28ed3..c42fd5a826c0 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -1061,7 +1061,7 @@ static const struct ibm_arch_vec ibm_architecture_vec_template __initconst = {
>  		.virt_base = cpu_to_be32(0xffffffff),
>  		.virt_size = cpu_to_be32(0xffffffff),
>  		.load_base = cpu_to_be32(0xffffffff),
> -		.min_rma = cpu_to_be32(512),		/* 512MB min RMA */
> +		.min_rma = cpu_to_be32(768),		/* 768MB min RMA */
>  		.min_load = cpu_to_be32(0xffffffff),	/* full client load */
>  		.min_rma_percent = 0,	/* min RMA percentage of total RAM */
>  		.max_pft_size = 48,	/* max log_2(hash table size) */
diff mbox series

Patch

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index fbb68fc28ed3..c42fd5a826c0 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -1061,7 +1061,7 @@  static const struct ibm_arch_vec ibm_architecture_vec_template __initconst = {
 		.virt_base = cpu_to_be32(0xffffffff),
 		.virt_size = cpu_to_be32(0xffffffff),
 		.load_base = cpu_to_be32(0xffffffff),
-		.min_rma = cpu_to_be32(512),		/* 512MB min RMA */
+		.min_rma = cpu_to_be32(768),		/* 768MB min RMA */
 		.min_load = cpu_to_be32(0xffffffff),	/* full client load */
 		.min_rma_percent = 0,	/* min RMA percentage of total RAM */
 		.max_pft_size = 48,	/* max log_2(hash table size) */