| Message ID | 20240905072215.337010-1-herve.codina@bootlin.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Delegated to: | Christophe Leroy |
| Headers | show |
| Series | soc: fsl: qe: ucc: Export ucc_mux_set_grant_tsa_bkpt | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 5 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 21 jobs. |
Le 05/09/2024 à 09:22, Herve Codina a écrit : > When TSA is compiled as module the following error is reported: > "ucc_mux_set_grant_tsa_bkpt" [drivers/soc/fsl/qe/tsa.ko] undefined! > > Indeed, the ucc_mux_set_grant_tsa_bkpt symbol is not exported. > > Simply export ucc_mux_set_grant_tsa_bkpt. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202409051409.fszn8rEo-lkp@intel.com/ > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu> Arnd, it is ok for you to take this patch directly ? Thanks Christophe > --- > drivers/soc/fsl/qe/ucc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c > index 21dbcd787cd5..892aa5931d5b 100644 > --- a/drivers/soc/fsl/qe/ucc.c > +++ b/drivers/soc/fsl/qe/ucc.c > @@ -114,6 +114,7 @@ int ucc_mux_set_grant_tsa_bkpt(unsigned int ucc_num, int set, u32 mask) > > return 0; > } > +EXPORT_SYMBOL(ucc_mux_set_grant_tsa_bkpt); > > int ucc_set_qe_mux_rxtx(unsigned int ucc_num, enum qe_clock clock, > enum comm_dir mode)
On Thu, Sep 5, 2024, at 07:31, Christophe Leroy wrote: > Le 05/09/2024 à 09:22, Herve Codina a écrit : >> When TSA is compiled as module the following error is reported: >> "ucc_mux_set_grant_tsa_bkpt" [drivers/soc/fsl/qe/tsa.ko] undefined! >> >> Indeed, the ucc_mux_set_grant_tsa_bkpt symbol is not exported. >> >> Simply export ucc_mux_set_grant_tsa_bkpt. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202409051409.fszn8rEo-lkp@intel.com/ >> Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > Arnd, it is ok for you to take this patch directly ? I've applied this one directly, but I'm not always paying attention to patches flying by, so if you have more fixes like this in the future, I recommend that you forward those to soc@kernel.org, either as a patch or a pull request. That way, I see them in patchwork and will apply them from there. Arnd
diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c index 21dbcd787cd5..892aa5931d5b 100644 --- a/drivers/soc/fsl/qe/ucc.c +++ b/drivers/soc/fsl/qe/ucc.c @@ -114,6 +114,7 @@ int ucc_mux_set_grant_tsa_bkpt(unsigned int ucc_num, int set, u32 mask) return 0; } +EXPORT_SYMBOL(ucc_mux_set_grant_tsa_bkpt); int ucc_set_qe_mux_rxtx(unsigned int ucc_num, enum qe_clock clock, enum comm_dir mode)
When TSA is compiled as module the following error is reported: "ucc_mux_set_grant_tsa_bkpt" [drivers/soc/fsl/qe/tsa.ko] undefined! Indeed, the ucc_mux_set_grant_tsa_bkpt symbol is not exported. Simply export ucc_mux_set_grant_tsa_bkpt. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202409051409.fszn8rEo-lkp@intel.com/ Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/soc/fsl/qe/ucc.c | 1 + 1 file changed, 1 insertion(+)