| Message ID | 20240528231123.136664-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 06ce0af34177a110d6a5cf71f924965b9b230691 |
| Headers | show |
| Series | soc/fsl/qbman: remove unused struct 'cgr_comp' | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | fail | Job manually cancelled |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On 5/28/24 19:11, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'cgr_comp' has been unused since > commit 96f413f47677 ("soc/fsl/qbman: fix issue in > qman_delete_cgr_safe()"). > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > drivers/soc/fsl/qbman/qman.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c > index 7e9074519ad2..4dc8aba33d9b 100644 > --- a/drivers/soc/fsl/qbman/qman.c > +++ b/drivers/soc/fsl/qbman/qman.c > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) > } > EXPORT_SYMBOL(qman_delete_cgr); > > -struct cgr_comp { > - struct qman_cgr *cgr; > - struct completion completion; > -}; > - > static void qman_delete_cgr_smp_call(void *p) > { > qman_delete_cgr((struct qman_cgr *)p); Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
* Sean Anderson (sean.anderson@linux.dev) wrote: > On 5/28/24 19:11, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > 'cgr_comp' has been unused since > > commit 96f413f47677 ("soc/fsl/qbman: fix issue in > > qman_delete_cgr_safe()"). > > > > Remove it. > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > --- > > drivers/soc/fsl/qbman/qman.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c > > index 7e9074519ad2..4dc8aba33d9b 100644 > > --- a/drivers/soc/fsl/qbman/qman.c > > +++ b/drivers/soc/fsl/qbman/qman.c > > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) > > } > > EXPORT_SYMBOL(qman_delete_cgr); > > > > -struct cgr_comp { > > - struct qman_cgr *cgr; > > - struct completion completion; > > -}; > > - > > static void qman_delete_cgr_smp_call(void *p) > > { > > qman_delete_cgr((struct qman_cgr *)p); > > Reviewed-by: Sean Anderson <sean.anderson@linux.dev> Hi Sean, Do you know who will pick this one up? I got a notification a while ago from a patchwork at linuxppc-dev marked 'Handled elsewhere' - but I'm not sure where. Thanks, Dave
"Dr. David Alan Gilbert" <linux@treblig.org> writes: > * Sean Anderson (sean.anderson@linux.dev) wrote: >> On 5/28/24 19:11, linux@treblig.org wrote: >> > From: "Dr. David Alan Gilbert" <linux@treblig.org> >> > >> > 'cgr_comp' has been unused since >> > commit 96f413f47677 ("soc/fsl/qbman: fix issue in >> > qman_delete_cgr_safe()"). >> > >> > Remove it. >> > >> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> >> > --- >> > drivers/soc/fsl/qbman/qman.c | 5 ----- >> > 1 file changed, 5 deletions(-) >> > >> > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c >> > index 7e9074519ad2..4dc8aba33d9b 100644 >> > --- a/drivers/soc/fsl/qbman/qman.c >> > +++ b/drivers/soc/fsl/qbman/qman.c >> > @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) >> > } >> > EXPORT_SYMBOL(qman_delete_cgr); >> > >> > -struct cgr_comp { >> > - struct qman_cgr *cgr; >> > - struct completion completion; >> > -}; >> > - >> > static void qman_delete_cgr_smp_call(void *p) >> > { >> > qman_delete_cgr((struct qman_cgr *)p); >> >> Reviewed-by: Sean Anderson <sean.anderson@linux.dev> > > Hi Sean, > Do you know who will pick this one up? > I got a notification a while ago from a patchwork at > linuxppc-dev marked 'Handled elsewhere' - but I'm not > sure where. drivers/soc/fsl was orphaned, but Christophe has recently volunteered to look after it. This patch looks trivial so I can just pick it up if you like Christophe? cheers
Le 22/07/2024 à 09:24, Michael Ellerman a écrit : > "Dr. David Alan Gilbert" <linux@treblig.org> writes: >> * Sean Anderson (sean.anderson@linux.dev) wrote: >>> On 5/28/24 19:11, linux@treblig.org wrote: >>>> From: "Dr. David Alan Gilbert" <linux@treblig.org> >>>> >>>> 'cgr_comp' has been unused since >>>> commit 96f413f47677 ("soc/fsl/qbman: fix issue in >>>> qman_delete_cgr_safe()"). >>>> >>>> Remove it. >>>> >>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> >>>> --- >>>> drivers/soc/fsl/qbman/qman.c | 5 ----- >>>> 1 file changed, 5 deletions(-) >>>> >>>> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c >>>> index 7e9074519ad2..4dc8aba33d9b 100644 >>>> --- a/drivers/soc/fsl/qbman/qman.c >>>> +++ b/drivers/soc/fsl/qbman/qman.c >>>> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) >>>> } >>>> EXPORT_SYMBOL(qman_delete_cgr); >>>> >>>> -struct cgr_comp { >>>> - struct qman_cgr *cgr; >>>> - struct completion completion; >>>> -}; >>>> - >>>> static void qman_delete_cgr_smp_call(void *p) >>>> { >>>> qman_delete_cgr((struct qman_cgr *)p); >>> >>> Reviewed-by: Sean Anderson <sean.anderson@linux.dev> >> >> Hi Sean, >> Do you know who will pick this one up? >> I got a notification a while ago from a patchwork at >> linuxppc-dev marked 'Handled elsewhere' - but I'm not >> sure where. > > drivers/soc/fsl was orphaned, but Christophe has recently volunteered to > look after it. > > This patch looks trivial so I can just pick it up if you like Christophe? > Sure Michael, you can pick it up. Thanks Christophe
On Wed, 29 May 2024 00:11:23 +0100, linux@treblig.org wrote: > 'cgr_comp' has been unused since > commit 96f413f47677 ("soc/fsl/qbman: fix issue in > qman_delete_cgr_safe()"). > > Remove it. > > > [...] Applied to powerpc/fixes. [1/1] soc/fsl/qbman: remove unused struct 'cgr_comp' https://git.kernel.org/powerpc/c/06ce0af34177a110d6a5cf71f924965b9b230691 cheers
diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 7e9074519ad2..4dc8aba33d9b 100644 --- a/drivers/soc/fsl/qbman/qman.c +++ b/drivers/soc/fsl/qbman/qman.c @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr) } EXPORT_SYMBOL(qman_delete_cgr); -struct cgr_comp { - struct qman_cgr *cgr; - struct completion completion; -}; - static void qman_delete_cgr_smp_call(void *p) { qman_delete_cgr((struct qman_cgr *)p);