| Message ID | 20240521030219.57439-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests/mm: Fix build warnings on ppc64 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On 5/20/24 8:02 PM, Michael Ellerman wrote: > Fix warnings like: > > In file included from uffd-unit-tests.c:8: > uffd-unit-tests.c: In function ‘uffd_poison_handle_fault’: > uffd-common.h:45:33: warning: format ‘%llu’ expects argument of type > ‘long long unsigned int’, but argument 3 has type ‘__u64’ {aka ‘long > unsigned int’} [-Wformat=] > > By switching to unsigned long long for u64 for ppc64 builds. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/mm/gup_test.c | 1 + > tools/testing/selftests/mm/uffd-common.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c > index bd335cf9bc0e..bdeaac67ff9a 100644 > --- a/tools/testing/selftests/mm/gup_test.c > +++ b/tools/testing/selftests/mm/gup_test.c > @@ -1,3 +1,4 @@ > +#define __SANE_USERSPACE_TYPES__ // Use ll64 > #include <fcntl.h> > #include <errno.h> > #include <stdio.h> > diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selftests/mm/uffd-common.h > index cc5629c3d2aa..a70ae10b5f62 100644 > --- a/tools/testing/selftests/mm/uffd-common.h > +++ b/tools/testing/selftests/mm/uffd-common.h > @@ -8,6 +8,7 @@ > #define __UFFD_COMMON_H__ > > #define _GNU_SOURCE > +#define __SANE_USERSPACE_TYPES__ // Use ll64 > #include <stdio.h> > #include <errno.h> > #include <unistd.h>
diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c index bd335cf9bc0e..bdeaac67ff9a 100644 --- a/tools/testing/selftests/mm/gup_test.c +++ b/tools/testing/selftests/mm/gup_test.c @@ -1,3 +1,4 @@ +#define __SANE_USERSPACE_TYPES__ // Use ll64 #include <fcntl.h> #include <errno.h> #include <stdio.h> diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selftests/mm/uffd-common.h index cc5629c3d2aa..a70ae10b5f62 100644 --- a/tools/testing/selftests/mm/uffd-common.h +++ b/tools/testing/selftests/mm/uffd-common.h @@ -8,6 +8,7 @@ #define __UFFD_COMMON_H__ #define _GNU_SOURCE +#define __SANE_USERSPACE_TYPES__ // Use ll64 #include <stdio.h> #include <errno.h> #include <unistd.h>
Fix warnings like: In file included from uffd-unit-tests.c:8: uffd-unit-tests.c: In function ‘uffd_poison_handle_fault’: uffd-common.h:45:33: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘__u64’ {aka ‘long unsigned int’} [-Wformat=] By switching to unsigned long long for u64 for ppc64 builds. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- tools/testing/selftests/mm/gup_test.c | 1 + tools/testing/selftests/mm/uffd-common.h | 1 + 2 files changed, 2 insertions(+)