diff mbox series

macintosh/mac_hid: add MODULE_DESCRIPTION()

Message ID 20240509-mac_hid-md-v1-1-4091f1e4e4e0@quicinc.com (mailing list archive)
State Accepted
Commit 50b5fed94e21c0992c79fafdd041c9863c1fd2d2
Headers show
Series macintosh/mac_hid: add MODULE_DESCRIPTION() | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 6 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 23 jobs.

Commit Message

Jeff Johnson May 10, 2024, 1:23 a.m. UTC 
Fix the make W=1 warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/macintosh/mac_hid.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
change-id: 20240509-mac_hid-md-7df0c349753c

Comments

Michael Ellerman July 4, 2024, 12:30 p.m. UTC | #1 
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> Fix the make W=1 warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/macintosh/mac_hid.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
> index 1ae3539beff5..eb7a173da071 100644
> --- a/drivers/macintosh/mac_hid.c
> +++ b/drivers/macintosh/mac_hid.c
> @@ -16,6 +16,7 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  
> +MODULE_DESCRIPTION("Macintosh mouse button 2+3 emulation");

I dropped the "Macintosh" from this, because AIUI the driver is not
actually mac specific, despite where it lives in the tree.

cheers
Michael Ellerman July 6, 2024, 11:10 p.m. UTC | #2 
On Thu, 09 May 2024 18:23:37 -0700, Jeff Johnson wrote:
> Fix the make W=1 warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o
> 
> 

Applied to powerpc/next.

[1/1] macintosh/mac_hid: add MODULE_DESCRIPTION()
      https://git.kernel.org/powerpc/c/50b5fed94e21c0992c79fafdd041c9863c1fd2d2

cheers
diff mbox series

Patch

diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index 1ae3539beff5..eb7a173da071 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -16,6 +16,7 @@ 
 #include <linux/module.h>
 #include <linux/slab.h>
 
+MODULE_DESCRIPTION("Macintosh mouse button 2+3 emulation");
 MODULE_LICENSE("GPL");
 
 static int mouse_emulate_buttons;