Message ID | 20240403080702.3509288-2-arnd@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 01acaf3aa75e1641442cc23d8fe0a7bb4226efb1 |
Headers | show |
Series | address all -Wunused-const warnings | expand |
Le 03/04/2024 à 10:06, Arnd Bergmann a écrit : > From: Arnd Bergmann <arnd@arndb.de> > > vmpic_msi_feature is only used conditionally, which triggers a rare > -Werror=unused-const-variable= warning with gcc: > > arch/powerpc/sysdev/fsl_msi.c:567:37: error: 'vmpic_msi_feature' defined but not used [-Werror=unused-const-variable=] > 567 | static const struct fsl_msi_feature vmpic_msi_feature = > > Hide this one in the same #ifdef as the reference so we can turn on > the warning by default. > > Fixes: 305bcf26128e ("powerpc/fsl-soc: use CONFIG_EPAPR_PARAVIRT for hcalls") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > arch/powerpc/sysdev/fsl_msi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c > index 8e6c84df4ca1..e205135ae1fe 100644 > --- a/arch/powerpc/sysdev/fsl_msi.c > +++ b/arch/powerpc/sysdev/fsl_msi.c > @@ -564,10 +564,12 @@ static const struct fsl_msi_feature ipic_msi_feature = { > .msiir_offset = 0x38, > }; > > +#ifdef CONFIG_EPAPR_PARAVIRT > static const struct fsl_msi_feature vmpic_msi_feature = { > .fsl_pic_ip = FSL_PIC_IP_VMPIC, > .msiir_offset = 0, > }; > +#endif > > static const struct of_device_id fsl_of_msi_ids[] = { > {
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index 8e6c84df4ca1..e205135ae1fe 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -564,10 +564,12 @@ static const struct fsl_msi_feature ipic_msi_feature = { .msiir_offset = 0x38, }; +#ifdef CONFIG_EPAPR_PARAVIRT static const struct fsl_msi_feature vmpic_msi_feature = { .fsl_pic_ip = FSL_PIC_IP_VMPIC, .msiir_offset = 0, }; +#endif static const struct of_device_id fsl_of_msi_ids[] = { {