Message ID | 20231122090312.114679-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers | show |
Series | powerpc: Use ARRAY_SIZE for array length | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> writes: > Use of macro ARRAY_SIZE to calculate array size minimizes > the redundant code and improves code reusability. > > ./arch/powerpc/xmon/ppc-opc.c:957:67-68: WARNING: Use ARRAY_SIZE. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7612 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > arch/powerpc/xmon/ppc-opc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) This code is copied from binutils, we don't take cleanup patches to it. See also the at least three times this has already been submitted :) https://lore.kernel.org/all/4ed43222-17b0-8355-f836-adabb453e432@csgroup.eu/ https://lore.kernel.org/linuxppc-dev/20181004171036.GA1907@embeddedor.com/ https://lore.kernel.org/linuxppc-dev/874lfxjnzl.fsf@concordia.ellerman.id.au/ cheers
diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c index 0774d711453e..d409d6113f82 100644 --- a/arch/powerpc/xmon/ppc-opc.c +++ b/arch/powerpc/xmon/ppc-opc.c @@ -954,8 +954,7 @@ const struct powerpc_operand powerpc_operands[] = { 0xff, 11, NULL, NULL, PPC_OPERAND_SIGNOPT }, }; -const unsigned int num_powerpc_operands = (sizeof (powerpc_operands) - / sizeof (powerpc_operands[0])); +const unsigned int num_powerpc_operands = ARRAY_SIZE(powerpc_operands); /* The functions used to insert and extract complicated operands. */
Use of macro ARRAY_SIZE to calculate array size minimizes the redundant code and improves code reusability. ./arch/powerpc/xmon/ppc-opc.c:957:67-68: WARNING: Use ARRAY_SIZE. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7612 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- arch/powerpc/xmon/ppc-opc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)