diff mbox series

[v1] powerpc/pseries: use kfree_sensitive() in plpks_gen_password()

Message ID 20230717092648.9752-1-duminjie@vivo.com (mailing list archive)
State Accepted
Commit ca2b746d5f91a37f01baedff54b9315a50ee617d
Headers show
Series [v1] powerpc/pseries: use kfree_sensitive() in plpks_gen_password() | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_ppctests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_selftests success Successfully ran 8 jobs.
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 6 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 23 jobs.

Commit Message

Minjie Du July 17, 2023, 9:26 a.m. UTC 
password might contain private information, so better use
kfree_sensitive to free it.
In plpks_gen_password() use kfree_sensitive().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 arch/powerpc/platforms/pseries/plpks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Ellerman Oct. 27, 2023, 9:59 a.m. UTC | #1 
On Mon, 17 Jul 2023 17:26:48 +0800, Minjie Du wrote:
> password might contain private information, so better use
> kfree_sensitive to free it.
> In plpks_gen_password() use kfree_sensitive().
> 
> 

Applied to powerpc/next.

[1/1] powerpc/pseries: use kfree_sensitive() in plpks_gen_password()
      https://git.kernel.org/powerpc/c/ca2b746d5f91a37f01baedff54b9315a50ee617d

cheers
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
index b0658ea3e..3441e616e 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -150,7 +150,7 @@  static int plpks_gen_password(void)
 		ospasswordlength = maxpwsize;
 		ospassword = kzalloc(maxpwsize, GFP_KERNEL);
 		if (!ospassword) {
-			kfree(password);
+			kfree_sensitive(password);
 			return -ENOMEM;
 		}
 		memcpy(ospassword, password, ospasswordlength);
@@ -163,7 +163,7 @@  static int plpks_gen_password(void)
 		}
 	}
 out:
-	kfree(password);
+	kfree_sensitive(password);
 
 	return pseries_status_to_err(rc);
 }