| Message ID | 20230615164113.2270698-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [1/2] PCI: layerscape: Add support for Link down notification | expand |
O Thu, Jun 15, 2023 at 12:41:11PM -0400, Frank Li wrote: > Add support to pass Link down notification to Endpoint function driver > so that the LINK_DOWN event can be processed by the function. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- @Lorenzo: No comment over 1 months. Just change layerscape and 1 line code change. Could you please consider pick this up? Frank Li > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index de4c1758a6c3..4e4fdd1dfea7 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -88,6 +88,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > > dev_dbg(pci->dev, "Link up\n"); > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > + pci_epc_linkdown(pci->ep.epc); > dev_dbg(pci->dev, "Link down\n"); > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > dev_dbg(pci->dev, "Hot reset\n"); > -- > 2.34.1 >
On Thu, Jun 15, 2023 at 12:41:11PM -0400, Frank Li wrote: > Add support to pass Link down notification to Endpoint function driver > so that the LINK_DOWN event can be processed by the function. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> One nit below. With that, Acked-by: Manivannan Sadhasivam <mani@kernel.org> > --- > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index de4c1758a6c3..4e4fdd1dfea7 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -88,6 +88,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > > dev_dbg(pci->dev, "Link up\n"); > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > + pci_epc_linkdown(pci->ep.epc); It'd be good to move this call after dev_dbg(). - Mani > dev_dbg(pci->dev, "Link down\n"); > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > dev_dbg(pci->dev, "Hot reset\n"); > -- > 2.34.1 >
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index de4c1758a6c3..4e4fdd1dfea7 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c @@ -88,6 +88,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) dev_dbg(pci->dev, "Link up\n"); } else if (val & PEX_PF0_PME_MES_DR_LDD) { + pci_epc_linkdown(pci->ep.epc); dev_dbg(pci->dev, "Link down\n"); } else if (val & PEX_PF0_PME_MES_DR_HRD) { dev_dbg(pci->dev, "Hot reset\n");
Add support to pass Link down notification to Endpoint function driver so that the LINK_DOWN event can be processed by the function. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + 1 file changed, 1 insertion(+)