diff mbox series

[v2,1/4] powerpc/rtas: unexport 'rtas' symbol

Message ID 20230124140448.45938-2-nathanl@linux.ibm.com (mailing list archive)
State Accepted
Commit 5ff92e2f274dc42a9e534473121273cd209d3501
Headers show
Series powerpc/rtas: exports and locking | expand

Commit Message

Nathan Lynch Jan. 24, 2023, 2:04 p.m. UTC 
No modular code needs access to the 'rtas' struct, so remove the
symbol export.

Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
 arch/powerpc/kernel/rtas.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Donnellan Feb. 2, 2023, 3:55 a.m. UTC | #1 
On Tue, 2023-01-24 at 08:04 -0600, Nathan Lynch wrote:
> No modular code needs access to the 'rtas' struct, so remove the
> symbol export.
> 
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>

A quick grep suggests that this is correct, and any modular code that
wants access to the rtas struct would clearly be doing something
extremely cursed that ought to be stopped.

Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
diff mbox series

Patch

diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index deded51a7978..6c5716b19d69 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -63,7 +63,6 @@  static inline void do_enter_rtas(unsigned long args)
 struct rtas_t rtas = {
 	.lock = __ARCH_SPIN_LOCK_UNLOCKED
 };
-EXPORT_SYMBOL(rtas);
 
 DEFINE_SPINLOCK(rtas_data_buf_lock);
 EXPORT_SYMBOL(rtas_data_buf_lock);