| Message ID | 20221110011929.3709774-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | afda85b963c12947e298ad85d757e333aa40fd74 |
| Headers | show |
| Series | powerpc/pseries: fix possible memory leak in ibmebus_bus_init() | expand |
On Thu, 10 Nov 2022 09:19:29 +0800, ruanjinjie wrote: > If device_register() returns error in ibmebus_bus_init(), name of kobject > which is allocated in dev_set_name() called in device_add() is leaked. > > As comment of device_add() says, it should call put_device() to drop > the reference count that was set in device_initialize() when it fails, > so the name can be freed in kobject_cleanup(). > > [...] Applied to powerpc/next. [1/1] powerpc/pseries: fix possible memory leak in ibmebus_bus_init() https://git.kernel.org/powerpc/c/afda85b963c12947e298ad85d757e333aa40fd74 cheers
diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index a870cada7acd..ed5fc70b7353 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -455,6 +455,7 @@ static int __init ibmebus_bus_init(void) if (err) { printk(KERN_WARNING "%s: device_register returned %i\n", __func__, err); + put_device(&ibmebus_bus_device); bus_unregister(&ibmebus_bus_type); return err;
If device_register() returns error in ibmebus_bus_init(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. As comment of device_add() says, it should call put_device() to drop the reference count that was set in device_initialize() when it fails, so the name can be freed in kobject_cleanup(). Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> --- arch/powerpc/platforms/pseries/ibmebus.c | 1 + 1 file changed, 1 insertion(+)