| Message ID | 20220921145255.20972-2-atrajeev@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [V2,1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc | expand |
> On 21-Sep-2022, at 8:22 PM, Athira Rajeev <atrajeev@linux.vnet.ibm.com> wrote: > > commit b55878c90ab9 ("perf test: Add test for branch stack sampling") > added test for branch stack sampling. There is a sanity check in the > beginning to skip the test if the hardware doesn't support branch stack > sampling. > > Snippet > <<>> > skip the test if the hardware doesn't support branch stack sampling > perf record -b -o- -B true > /dev/null 2>&1 || exit 2 > <<>> > > But the testcase also uses branch sample types: save_type, any. if any > platform doesn't support the branch filters used in the test, the testcase > will fail. In powerpc, currently mutliple branch filters are not supported > and hence this test fails in powerpc. Fix the sanity check to look at > the support for branch filters used in this test before proceeding with > the test. > > Fixes: b55878c90ab9 ("perf test: Add test for branch stack sampling") > Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com> > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > Reviewed-by: Kajol Jain <kjain@linux.ibm.com> > --- > tools/perf/tests/shell/test_brstack.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/test_brstack.sh b/tools/perf/tests/shell/test_brstack.sh > index c644f94a6500..ec801cffae6b 100755 > --- a/tools/perf/tests/shell/test_brstack.sh > +++ b/tools/perf/tests/shell/test_brstack.sh > @@ -12,7 +12,8 @@ if ! [ -x "$(command -v cc)" ]; then > fi > > # skip the test if the hardware doesn't support branch stack sampling > -perf record -b -o- -B true > /dev/null 2>&1 || exit 2 > +# and if the architecture doesn't support filter types: any,save_type,u > +perf record -b -o- -B --branch-filter any,save_type,u true > /dev/null 2>&1 || exit 2 Hi, Looking for review comments for this change. Thanks Athira > > TMPDIR=$(mktemp -d /tmp/__perf_test.program.XXXXX) > > -- > 2.31.1 >
Em Wed, Sep 21, 2022 at 08:22:54PM +0530, Athira Rajeev escreveu: > commit b55878c90ab9 ("perf test: Add test for branch stack sampling") > added test for branch stack sampling. There is a sanity check in the > beginning to skip the test if the hardware doesn't support branch stack > sampling. > > Snippet > <<>> > skip the test if the hardware doesn't support branch stack sampling > perf record -b -o- -B true > /dev/null 2>&1 || exit 2 > <<>> > > But the testcase also uses branch sample types: save_type, any. if any > platform doesn't support the branch filters used in the test, the testcase > will fail. In powerpc, currently mutliple branch filters are not supported > and hence this test fails in powerpc. Fix the sanity check to look at > the support for branch filters used in this test before proceeding with >> the test. Applied the tools/perf/ part - Arnaldo > Fixes: b55878c90ab9 ("perf test: Add test for branch stack sampling") > Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com> > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > Reviewed-by: Kajol Jain <kjain@linux.ibm.com> > --- > tools/perf/tests/shell/test_brstack.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/test_brstack.sh b/tools/perf/tests/shell/test_brstack.sh > index c644f94a6500..ec801cffae6b 100755 > --- a/tools/perf/tests/shell/test_brstack.sh > +++ b/tools/perf/tests/shell/test_brstack.sh > @@ -12,7 +12,8 @@ if ! [ -x "$(command -v cc)" ]; then > fi > > # skip the test if the hardware doesn't support branch stack sampling > -perf record -b -o- -B true > /dev/null 2>&1 || exit 2 > +# and if the architecture doesn't support filter types: any,save_type,u > +perf record -b -o- -B --branch-filter any,save_type,u true > /dev/null 2>&1 || exit 2 > > TMPDIR=$(mktemp -d /tmp/__perf_test.program.XXXXX) > > -- > 2.31.1
Arnaldo Carvalho de Melo <acme@kernel.org> writes: > Em Wed, Sep 21, 2022 at 08:22:54PM +0530, Athira Rajeev escreveu: >> commit b55878c90ab9 ("perf test: Add test for branch stack sampling") >> added test for branch stack sampling. There is a sanity check in the >> beginning to skip the test if the hardware doesn't support branch stack >> sampling. >> >> Snippet >> <<>> >> skip the test if the hardware doesn't support branch stack sampling >> perf record -b -o- -B true > /dev/null 2>&1 || exit 2 >> <<>> >> >> But the testcase also uses branch sample types: save_type, any. if any >> platform doesn't support the branch filters used in the test, the testcase >> will fail. In powerpc, currently mutliple branch filters are not supported >> and hence this test fails in powerpc. Fix the sanity check to look at >> the support for branch filters used in this test before proceeding with >>> the test. > > Applied the tools/perf/ part Thanks, I have the other two queued. cheers
diff --git a/tools/perf/tests/shell/test_brstack.sh b/tools/perf/tests/shell/test_brstack.sh index c644f94a6500..ec801cffae6b 100755 --- a/tools/perf/tests/shell/test_brstack.sh +++ b/tools/perf/tests/shell/test_brstack.sh @@ -12,7 +12,8 @@ if ! [ -x "$(command -v cc)" ]; then fi # skip the test if the hardware doesn't support branch stack sampling -perf record -b -o- -B true > /dev/null 2>&1 || exit 2 +# and if the architecture doesn't support filter types: any,save_type,u +perf record -b -o- -B --branch-filter any,save_type,u true > /dev/null 2>&1 || exit 2 TMPDIR=$(mktemp -d /tmp/__perf_test.program.XXXXX)
commit b55878c90ab9 ("perf test: Add test for branch stack sampling") added test for branch stack sampling. There is a sanity check in the beginning to skip the test if the hardware doesn't support branch stack sampling. Snippet <<>> skip the test if the hardware doesn't support branch stack sampling perf record -b -o- -B true > /dev/null 2>&1 || exit 2 <<>> But the testcase also uses branch sample types: save_type, any. if any platform doesn't support the branch filters used in the test, the testcase will fail. In powerpc, currently mutliple branch filters are not supported and hence this test fails in powerpc. Fix the sanity check to look at the support for branch filters used in this test before proceeding with the test. Fixes: b55878c90ab9 ("perf test: Add test for branch stack sampling") Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Reviewed-by: Kajol Jain <kjain@linux.ibm.com> --- tools/perf/tests/shell/test_brstack.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)