diff mbox series

[3/3] tools/testing/selftests/powerpc: Update the bhrb filter sampling test to test for multiple branch filters

Message ID 20220913115546.36179-3-atrajeev@linux.vnet.ibm.com (mailing list archive)
State Changes Requested
Headers show
Series [1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_ppctests fail ppctests (ubuntu-16.04, ppc64) failed at step build.
snowpatch_ozlabs/github-powerpc_perf success Successfully ran 10 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 6 jobs.
snowpatch_ozlabs/github-powerpc_selftests success Successfully ran 10 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 23 jobs.

Commit Message

Athira Rajeev Sept. 13, 2022, 11:55 a.m. UTC 
For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type,
ie branch filters are supported. The testcase "bhrb_filter_map_test"
tests the valid and invalid filter maps in different powerpc platforms.
Update this testcase to include scenario to cover multiple branch
filters at sametime. Since powerpc doesn't support multiple filters at
sametime, expect failure during perf_event_open.

Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
---
 .../powerpc/pmu/sampling_tests/bhrb_filter_map_test.c    | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

kajoljain Sept. 16, 2022, 1:07 p.m. UTC | #1 
On 9/13/22 17:25, Athira Rajeev wrote:
> For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type,
> ie branch filters are supported. The testcase "bhrb_filter_map_test"
> tests the valid and invalid filter maps in different powerpc platforms.
> Update this testcase to include scenario to cover multiple branch
> filters at sametime. Since powerpc doesn't support multiple filters at
> sametime, expect failure during perf_event_open.
> 
> Reported-by: Disha Goel <disgoel@linux.vnet.ibm.com>
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> ---
>  .../powerpc/pmu/sampling_tests/bhrb_filter_map_test.c    | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> index 8182647c63c8..605669d4e4cb 100644
> --- a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> +++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> @@ -96,6 +96,15 @@ static int bhrb_filter_map_test(void)
>  		}
>  	}
>  

Patch looks good to me.

Reviewed-By: Kajol Jain <kjain@linux.ibm.com>

Thanks,
Kajol Jain


> +	/*
> +	 * Combine filter maps which includes a valid branch filter and an invalid branch
> +	 * filter. Example: any ( PERF_SAMPLE_BRANCH_ANY) and save_type
> +	 * (PERF_SAMPLE_BRANCH_TYPE_SAVE).
> +	 * The perf_event_open should fail in this case.
> +	 */
> +	event.attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY | PERF_SAMPLE_BRANCH_TYPE_SAVE;
> +	FAIL_IF(!event_open(&event));
> +
>  	return 0;
>  }
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
index 8182647c63c8..605669d4e4cb 100644
--- a/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
+++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
@@ -96,6 +96,15 @@  static int bhrb_filter_map_test(void)
 		}
 	}
 
+	/*
+	 * Combine filter maps which includes a valid branch filter and an invalid branch
+	 * filter. Example: any ( PERF_SAMPLE_BRANCH_ANY) and save_type
+	 * (PERF_SAMPLE_BRANCH_TYPE_SAVE).
+	 * The perf_event_open should fail in this case.
+	 */
+	event.attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY | PERF_SAMPLE_BRANCH_TYPE_SAVE;
+	FAIL_IF(!event_open(&event));
+
 	return 0;
 }